Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Phase 1-10 complete (branding, DDD models, UI/UX, test fixes, .gitignore cleanup) #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat: Phase 1-10 complete (branding, DDD models, UI/UX, test fixes, .gitignore cleanup) #214
Changes from all commits
5de35b9667b2d8a95099d8c8de0f5531dc72a2348bce025d00a919fa410231fddeb80b523aa506c68ce3030c6cf740035467d1db19dcacec53ccc3ac5018304ed3d0104ef1bc90b8a8293a24fb85dc1f8File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle first-write races on tenant config creation.
Both handlers do a read-then-insert flow on a unique key. Two concurrent requests for a new user can collide and throw a 500 on commit.
Suggested hardening
Also applies to: 86-95
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Require authentication on DAV methods before processing requests.
The handler currently accepts unauthenticated DAV traffic (including
PUT), which exposes write-capable behavior to anonymous clients.Suggested hardening
Also applies to: 44-48
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build DAV XML values safely and with the correct DAV base path.
hrefcurrently points to/api/dav/...(route is/dav/...), and raw path values are inserted into XML without escaping.Suggested fix
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.