fix(frontend): honor confidence percentage contract - #1559
seonghobae wants to merge 6 commits into
Conversation
Remove the ambiguous ratio heuristic that made adjacent percentage values jump from 100% to 2%. Align EmailDetail fixtures with the backend's documented 0-100 response contract. Assisted-by: OpenAI Codex Signed-off-by: Seongho Bae <me@seonghobae.me>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe confidence formatter now treats finite inputs as literal percentages, clamps them to 0–100, and rounds them. Unit tests and EmailDetail mocks now use percentage-based confidence values. ChangesConfidence Percentage Contract
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Confidence values are now displayed as backend-provided percentages rather than inferred ratios, preventing fractional values from being shown as incorrect percentages. The updated tests cover the formatter behavior and EmailDetail mock responses, with no remaining merge-readiness risk identified. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d2a6ea892
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep pilot and full-product buyer flows on the backend's 0-100 confidence contract so screenshots and product events do not report 1% for an 86% result. Assisted-by: OpenAI Codex Signed-off-by: Seongho Bae <me@seonghobae.me>
Pull request was converted to draft
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a081359a29
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Record the backend 0-100 integer contract so copied frontend and smoke fixtures cannot silently reintroduce ratio values. Assisted-by: OpenAI Codex Signed-off-by: Seongho Bae <me@seonghobae.me>
Co-Authored-By: Codex <codex@openai.com> Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Exact-head repair evidence for
|
|
Current-head boundary audit found that the documented integer 0–100 contract was still not enforced: non-integer payloads were silently rounded ( |
Integrate the two recorded AGENTS recurrence rules from product PRs #1559 and #1300 into the existing documentation owner. Preserve the full predecessor delta and built-in execution path; no product runtime, release, or protected merge is claimed. Co-Authored-By: Codex <noreply@openai.com> Signed-off-by: Seongho Bae <me@seonghobae.me>
문제
toConfidencePercent가0..1값을 비율로 추측해 backend/api/llm/summarize의confidence: int | None, 0..100계약과 다른 표시·quality-guardrail telemetry를 만들 수 있었습니다.Current exact identity
develop@042b0c70531b229af3acbd0421a2f23098d848b31a7e10ea12f27d5d123d7528eae069d4f43a5194ahead_by=6,behind_by=0, merge base = protecteddevelopAGENTS.md는 더 이상 이 product/source PR의 delta가 아닙니다.RED → causal repair
9d2a6ea892a8367713976e15babcbd337d06895d에서 value-based 0–1 inference를 제거하고 frontend helper/test fixture를 backend 0–100 단위에 맞췄습니다.confidence: 0.86을 반환해 1% 표시와 falselow_confidenceevent를 만들 수 있음을 찾았습니다.a081359a2911dcde31965b797ef9c96366770463에서 두 fixture를86으로 고쳤고 해당 finding은 current source에서 해소됐습니다.4d6b697e97f7f0d98700292680970b41e7b12c48에서 shared boundary가0.856,85.5같은 non-integer malformed 값까지 silently round하지 않고 reject하도록 고쳤습니다.-0은0으로 정규화합니다.AGENTS.md에 직접 추가했지만, live Naruon docs stack docs(governance): align AGENTS/CLAUDE LLM guidance with canonical orchestrator owner #1549/#1566이 이미AGENTS.mdcanonical writer입니다. 병렬 docs ownership을 유지하지 않고 direct descendant1a7e10ea12f27d5d123d7528eae069d4f43a5194에서 protected-base AGENTS blob을 non-force로 복원했습니다. 실행 가능한 recurrence contract는confidence.test.ts,EmailDetail.test.tsx, pilot/full-product smoke에 그대로 남습니다. valid AGENTS finding은 docs(agents): 증거 기반 작업 절차 정리 #1566 PR authority로 승계했으며 그 docs stack exact head에 실제 반영되기 전에는 landed로 간주하지 않습니다.이 PR은 #1436 전체를 supersede하지 않습니다. confidence-unit boundary만 독립적으로 소유하며 #1436의 Storybook/design-system/product-event delta는 별도입니다.
Fresh evidence boundary
새 exact head에 repository-owned PR workflows가 다시 생성됐습니다: Application CI
33942459386, Security Scan33942459380, Semgrep33942459468, CodeQL PR33942459375, Bandit33942459369, Docker33942459471. 현재 모두 queued입니다. earlier-head checks/reviews는 통과 증거로 승계하지 않습니다. qualifying post-last-push independentAPPROVEDreview도 없습니다. resolved historical threads는 current source finding이 다시 나타나지 않는다는 사실만 나타내며 merge authorization이 아닙니다.Keep Draft until one unchanged exact head has every then-live repository/organization required check terminal-success, zero valid unresolved findings/threads, and the live last-push approval requirement satisfied. No self-approval, bypass/admin merge, force-push, destructive rebase, dummy/no-op requeue commit, synthetic status, gate weakening, or predecessor-evidence transfer.
UI Delivery Gate