Skip to content

style(attachments): apply parser formatting - #1444

Merged
seonghobae merged 1 commit into
feat/hwp-hwpx-attachment-recognitionfrom
codex/1353-parser-formatting
Aug 21, 2026
Merged

style(attachments): apply parser formatting#1444
seonghobae merged 1 commit into
feat/hwp-hwpx-attachment-recognitionfrom
codex/1353-parser-formatting

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Verification

  • ruff format --check backend/services/attachment_parser.py backend/tests/test_attachment_parser.py backend/tests/test_attachment_parser_hwp_signature.py backend/tests/test_attachment_parser_hwpx_bounds.py
  • focused attachment parser tests: 99 passed
  • git diff --check

Parent PR: #1353


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b773f935-7b46-4231-bcb7-8004465436c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

seonghobae commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@opencode-agent @cwl-noema-review

Current-head review request for the formatter-only stacked PR #1444.

Exact head: 4f6d91a
Parent/base branch: feat/hwp-hwpx-attachment-recognition at 315ea05

Read the complete four-file diff. Confirm it is formatting-only, remains a safe stack on #1353, introduces no generated or unrelated changes, and preserves the focused HWP/HW/HWPX parser tests. Return a current-head substantive verdict with path:line evidence; do not reuse predecessor evidence or edit/approve from this request.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@seonghobae
seonghobae merged commit 9be0992 into feat/hwp-hwpx-attachment-recognition Aug 21, 2026
2 of 3 checks passed
@seonghobae
seonghobae deleted the codex/1353-parser-formatting branch August 21, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant