feat(mail): open recognized HWPX text from email attachments - #1406
feat(mail): open recognized HWPX text from email attachments#1406seonghobae wants to merge 3 commits into
Conversation
List the current email's attachments with the same opaque asset_key as the Data preview contract so a buyer can read ordered HWPX paragraphs from mail without treating missing text as empty content. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
|
Caution Review failedAn error occurred during the review process. Please try again later. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughEmail detail and thread responses now expose opaque attachment references. The dashboard renders selected attachments through the repository preview endpoint and handles HWPX recognition states without exposing internal identifiers. ChangesMail attachment preview
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This PR adds recognized HWPX attachment previews to email while preserving existing preview behavior and unavailable/pending states. No actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant User
participant EmailDetail
participant MailAttachmentPreview
participant RepositoryAssetPreviewPanel
User->>EmailDetail: select email
EmailDetail->>MailAttachmentPreview: provide attachment references
MailAttachmentPreview->>RepositoryAssetPreviewPanel: request preview by asset_key
RepositoryAssetPreviewPanel-->>MailAttachmentPreview: return preview state and paragraphs
MailAttachmentPreview-->>User: display selected attachment
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR governance metadata gate is not ready for
|
Wire the inherited 다시 확인 control to re-fetch the same opaque mail attachment preview so the stacked parent refresh stays reachable. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Bring Draft #1407 onto independently resolved live #1406 b83a0da. Previous parent 304d5af is stale. Keep #1404/#1406 pending 다시 확인 refresh and mail reachability together with the fail-closed Inkspan edit handoff. No rebase, squash, or force-push. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
@coderabbitai review The rolling-hour window from #1404 |
|
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
opencode-agent
Bot
added
priority: medium
2 participants
Summary
c4fd7223c1885826d5952b3cb6a083a3d56ac509. Live feat(data): show recognized HWPX paragraph text in attachment preview #1404 is independently resolved asf21811379c1cc2435eadb41bb2746b4887947d53oncursor/hwpx-recognized-text-preview-b246(itself on live feat(hwpx): recognize ordered section text with provenance #13730fcf4d85dd70d4f2ee9dd0296fc454f764ae5326/ Ready feat(attachments): recognize HWP and HWPX parser boundaries #135370683266/ developdd8d1519).304d5afa605c9121f23b9c68884d39ec3508f81e(still sitting on stale feat(data): show recognized HWPX paragraph text in attachment preview #1404).b83a0da03b46a447f9710b5f91d245f5b1783dfa.f21811379c1cc2435eadb41bb2746b4887947d53(independently resolved from GitHub before the merge;git merge-base HEAD origin/cursor/hwpx-recognized-text-preview-b246equals that SHA).d2e201ccof live feat(data): show recognized HWPX paragraph text in attachment preview #1404 into this branch. No rebase, squash, or force-push.다시 확인) onRepositoryAssetPreviewPanel. Mail now passesonRefreshPreviewso that inherited control re-fetches the same opaque mailasset_key. feat(data): show recognized HWPX paragraph text in attachment preview #1404 recognition/preview semantics and feat(mail): open recognized HWPX text from email attachments #1406 mail-attachment reachability are unchanged.304d5afa. It needs a later retarget onto this new exact head.304d5afaor stale feat(data): show recognized HWPX paragraph text in attachment preview #1404c4fd7223does not apply tob83a0da0. Fresh review is required on this exact head.EmailDetailnow lists the email's own attachments and opens recognized HWPX paragraph text through the same signed/api/data/repository-assets/{asset_key}/previewcontract as Data (feat(data): show recognized HWPX paragraph text in attachment preview #1404). Buyers no longer have to leave Mail and hunt the latest-8 Data quality surface.GET /api/emails/{id}and thread messages includeattachments: [{ asset_key, file_name, parser_family }]only. Theasset_keyis the same HMAC-SHA256 opaque key Data already uses. Sequential attachment ids, raw message/thread ids, and recognized text stay off the mail list payload.MailAttachmentPreviewreusesRepositoryAssetPreviewPanel. Pending stays wait-or-choose-another-file (plus inherited다시 확인). Failed/unavailable stays choose-another-file. Missing text is never rendered as empty document content. Unknown/cross-workspace 404 stays indistinguishable unavailable.Customer next action
Open the email, select the HWPX file in 첨부 파일, and read the recognized paragraphs. If the preview is still pending, wait, choose another file, or use 다시 확인. If recognition failed or the file is unavailable, choose another file. Never treat a blank preview as empty document content.
Test plan
Results on exact head
b83a0da03b46a447f9710b5f91d245f5b1783dfa:TEST_DATABASE_URL). Ruff clean. No Timeout/Fatal/Warn/Denied.CI investigation (2026-08-18)
PR Governance / metadata-only gate evaluationonb83a0da03b46a447f9710b5f91d245f5b1783dfa(95549606003), summary:Draft PR: merge automation is paused.cursor/hwpx-recognized-text-preview-b246);app-ci.ymlonly runs fordevelop/master/release/**.2026-08-18T01:32:39Z. Governance re-evaluated the same head: comment now says no current blocking failures remain;metadata-only gate evaluationis an in-progress wait (Ruleset-governed branch: no legacy required status contexts; CWL/PR rulesets apply to~DEFAULT_BRANCHonly).mergeStateStatus=CLEAN.Notes
f21811379c1cc2435eadb41bb2746b4887947d53. Do not self-APPROVE, merge, request Copilot, dummy-commit, empty-requeue, or force-cancel from this agent.Summary by CodeRabbit
New Features
Bug Fixes