Skip to content

⚡ Bolt: [성능 개선] NetworkGraph 이벤트 핸들러의 O(N) 노드 검색을 O(1) Map 검색으로 변경 - #1388

Merged
seonghobae merged 1 commit into
developfrom
bolt-optimize-findNodeLabel-1387274448261599703
Aug 17, 2026
Merged

⚡ Bolt: [성능 개선] NetworkGraph 이벤트 핸들러의 O(N) 노드 검색을 O(1) Map 검색으로 변경#1388
seonghobae merged 1 commit into
developfrom
bolt-optimize-findNodeLabel-1387274448261599703

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

💡 무엇을: NetworkGraph.tsx의 노드 선택 이벤트 핸들러(selectNode, selectGraphNode)에서 노드 라벨을 찾을 때 O(N) 시간 복잡도를 가진 findNodeLabel 대신 이미 계산된 O(1) nodeMap과 객체 프로퍼티를 직접 사용하도록 수정했습니다.
🎯 왜: 데이터 양이 늘어날 경우 이벤트 발생 시 Array.prototype.find() 호출로 인한 성능 병목(O(N))을 방지하기 위함입니다.
📊 영향: 그래프에서 노드 클릭 등 상호작용 시 불필요한 배열 순회를 제거하여 응답성을 개선했습니다.
🔬 측정 방법: 노드가 많은 그래프에서 클릭 이벤트 시의 지연 시간을 확인하여 개선되었는지 측정할 수 있습니다.


PR created automatically by Jules for task 1387274448261599703 started by @seonghobae

Summary by CodeRabbit

  • Bug Fixes
    • Improved network graph node selection label retrieval.
    • Preserved existing selection behavior and displayed text.

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2acd781d-76c8-42c0-a3d0-f86fd093fa6f

📥 Commits

Reviewing files that changed from the base of the PR and between bc98789 and 8ac2fab.

⛔ Files ignored due to path filters (1)
  • frontend/src/components/NetworkGraph.tsx.out is excluded by !**/*.out
📒 Files selected for processing (1)
  • frontend/src/components/NetworkGraph.tsx

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Node selection in NetworkGraph.tsx now resolves labels through the precomputed nodeMap or the selected node property. Selection behavior and displayed text remain unchanged.

Changes

Network node selection

Layer / File(s) Summary
Replace array label lookups
frontend/src/components/NetworkGraph.tsx
selectNode uses nodeMap for label lookup. selectGraphNode reads the label directly from the selected node.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 8ac2f

This localized performance change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Possibly related PRs

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change from O(N) node searches to O(1) Map lookups in NetworkGraph event handlers.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bolt-optimize-findNodeLabel-1387274448261599703

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit 90d3c46 into develop Aug 17, 2026
45 checks passed
@seonghobae
seonghobae deleted the bolt-optimize-findNodeLabel-1387274448261599703 branch August 17, 2026 02:26
seonghobae added a commit to ContextualWisdomLab/.github that referenced this pull request Aug 19, 2026
Scan ContextualWisdomLab/naruon protected develop at minute 11 so live
platform PRs receive the same bounded RCA worker as Clearfolio, DiskSage,
and fast-mlsirm. Keep NVIDIA_NIM_API_KEY on the worker and never introduce
COPILOT_GITHUB_TOKEN.

Refs ContextualWisdomLab/naruon#1388 ContextualWisdomLab/naruon#1387
ContextualWisdomLab/naruon#1380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant