Skip to content

fix(a11y): show keyboard focus on OIDC actions #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonghobae wants to merge 29 commits into
base: develop
Choose a base branch
from
Open

fix(a11y): show keyboard focus on OIDC actions #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
3324848
🎨 Palette: OIDC 로그인 및 로그아웃 버튼의 키보드 접근성 개선
seonghobae Aug 4, 2026
48e0d86
chore(a11y): remove bot journal artifact
seonghobae Aug 5, 2026
04976dc
test(a11y): lock OIDC focus indicators
seonghobae Aug 5, 2026
8bbd54a
docs(a11y): record OIDC focus boundary
seonghobae Aug 5, 2026
0dbf41f
test(a11y): locate formatted OIDC buttons
seonghobae Aug 5, 2026
a28e004
merge(develop): refresh OIDC keyboard focus indicators
seonghobae Aug 6, 2026
e03caee
Merge branch 'develop' into palette/oidc-button-a11y-1629624194230680…
seonghobae Aug 7, 2026
95ba8f9
Merge develop into OIDC focus accessibility fix
seonghobae Aug 14, 2026
cb3bb00
🛡️ Sentinel: [HIGH] Fix SSRF vulnerability in SettingsLayout
seonghobae Aug 14, 2026
0509c0d
Merge branch 'develop' into palette/oidc-button-a11y-1629624194230680…
opencode-agent[bot] Aug 14, 2026
e8bc461
🛡️ Sentinel: [HIGH] Fix SSRF vulnerability in SettingsLayout and igno…
seonghobae Aug 14, 2026
b6365aa
Merge branch 'develop' into palette/oidc-button-a11y-1629624194230680…
opencode-agent[bot] Aug 15, 2026
fb53de0
🛡️ Sentinel: [HIGH] Fix SSRF vulnerability in SettingsLayout and reve…
seonghobae Aug 15, 2026
385ed69
🛡️ Sentinel: [HIGH] Fix SSRF vulnerability in SettingsLayout and igno…
seonghobae Aug 15, 2026
27f9e36
🛡️ Sentinel: [HIGH] Fix SSRF vulnerability in SettingsLayout and igno…
seonghobae Aug 15, 2026
61052d2
Merge branch 'develop' into palette/oidc-button-a11y-1629624194230680…
opencode-agent[bot] Aug 15, 2026
7775834
fix(a11y): reconstruct OIDC focus lane on current develop
seonghobae Aug 15, 2026
76ad751
Merge develop into palette/oidc-button-a11y-16296241942306803859
seonghobae Aug 15, 2026
ce46f13
Merge protected develop into OIDC focus accessibility
seonghobae Aug 15, 2026
7db580d
Merge branch 'develop' into palette/oidc-button-a11y-1629624194230680…
seonghobae Aug 17, 2026
7be622c
merge(develop): reconcile OIDC focus accessibility
seonghobae Aug 18, 2026
3fc0daf
🛡️ Sentinel: [HIGH] Fix SSRF vulnerability in SettingsLayout and igno…
seonghobae Aug 18, 2026
5105ddb
🛡️ Sentinel: [HIGH] Fix SSRF vulnerability in SettingsLayout and igno…
seonghobae Aug 18, 2026
077597e
Merge develop into OIDC accessibility branch
seonghobae Aug 20, 2026
a27ebb0
Merge remote-tracking branch 'origin/develop' into fix/pr1241-current
seonghobae Aug 21, 2026
409eb58
🎨 Palette: OIDC 로그인 및 로그아웃 버튼의 키보드 접근성 개선
seonghobae Aug 22, 2026
b94e19d
fix(a11y): restore develop baseline and keep OIDC focus-visible delta…
seonghobae Aug 24, 2026
fb7e63d
fix(security): bump aiohttp to 3.14.3 and js-yaml to 4.3.1 (#1241)
seonghobae Aug 24, 2026
ea3eb42
Merge branch 'develop' into palette/oidc-button-a11y-1629624194230680…
seonghobae Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions frontend/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions frontend/pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ supportedArchitectures:

overrides:
brace-expansion: "5.0.9"
js-yaml: "4.3.1"

@devin-ai-integration devin-ai-integration Bot Aug 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Dependency bumps unrelated to the a11y change

Beyond the OIDC focus styling, this PR bumps aiohttp 3.14.1->3.14.3 in requirements-strix-ci-hashes.txt and adds a js-yaml: "4.3.1" override in pnpm-workspace.yaml. Both are unrelated to the accessibility change and are scope drift; the lockfile does carry a matching js-yaml@4.3.1 resolution, so the override is internally consistent.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@seonghobae seonghobae Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency bumps are merge-gate remediation, not scope drift: osv-scan flags aiohttp@3.14.1 (PYSEC-2026-3545/3546/3547) and js-yaml@4.3.0 (GHSA-5p4m-2wfm-xmqj) at the develop baseline itself, and these files sit on the required-check path for this PR's merge ref. The changes are minimal — a single hash-block splice for aiohttp 3.14.3 (all other pins byte-identical) and one pnpm-workspace.yaml override + lockfile refresh for js-yaml 4.3.1.

postcss: "8.5.24"
sharp: "0.35.0"
undici: 8.9.0
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/SettingsLayout.tsx
View file
Open in desktop
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -1619,7 +1619,7 @@ export function SettingsLayout() {
onClick={handleOidcLogin}
disabled={!oidcBrowserConfig}
title={!oidcBrowserConfig ? "OIDC 브라우저 설정이 없습니다" : "OIDC 로그인"}
className="rounded-lg bg-primary px-4 py-2 text-sm font-bold text-primary-foreground shadow-sm transition-colors hover:bg-primary/90 disabled:cursor-not-allowed disabled:opacity-50"
className="rounded-lg bg-primary px-4 py-2 text-sm font-bold text-primary-foreground shadow-sm transition-colors hover:bg-primary/90 disabled:cursor-not-allowed disabled:opacity-50 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring/40"
>
OIDC 로그인
</button>
Expand All @@ -1628,7 +1628,7 @@ export function SettingsLayout() {
onClick={handleOidcLogout}
disabled={!oidcSessionClaims.userId}
title={!oidcSessionClaims.userId ? "로그인된 세션이 없습니다" : "로그아웃"}
className="rounded-lg border border-border px-4 py-2 text-sm font-bold text-foreground transition-colors hover:bg-accent disabled:cursor-not-allowed disabled:opacity-50"
className="rounded-lg border border-border px-4 py-2 text-sm font-bold text-foreground transition-colors hover:bg-accent disabled:cursor-not-allowed disabled:opacity-50 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring/40"
>
로그아웃
</button>
Expand Down
Loading
Loading