🎨 Palette: [UX 개선] 비활성화된 로딩 버튼에 aria-busy 속성 추가 by seonghobae · Pull Request #1219 · ContextualWisdomLab/naruon

seonghobae · 2026-08-03T02:13:01Z

변경 사항

프로젝트 후보 확정 요청이 진행 중일 때 버튼에 aria-busy={confirmSubmitting}를 적용해 보조 기술이 비동기 처리 상태를 인식하도록 했습니다.
로딩 버튼의 실제 disabled 상태, aria-busy 전환, 진행 중 문구, 완료 상태를 검증하는 전용 Vitest 회귀 테스트를 추가했습니다.
중앙 필수 워크플로 정책을 위반하던 일회성 저장소 로컬 리뷰 디스패처를 제거했습니다. OpenCode·Strix·병합 자동화는 ContextualWisdomLab/.github의 중앙 워크플로만 사용합니다.

검증 계약

frontend/src/components/ProjectsLayout.accessibility.test.tsx
- 요청 전 aria-busy="false"
- 요청 중 disabled=true, aria-busy="true", 확정 저장 중
- 성공 후 aria-busy="false", 프로젝트 후보 확정됨
Application CI, Dependency Review, Security Scan, Bandit, Semgrep, Docker validation을 현재 head에서 재검증합니다.

PR created automatically by Jules for task 13634237694443312021 started by @seonghobae

Summary by CodeRabbit

Accessibility
- Confirmation buttons now communicate their loading state to assistive technologies during submission.
Bug Fixes
- Improved confirmation feedback by clearly indicating when a request is processing and when it has completed.
Tests
- Added coverage validating confirmation button states, messaging, and request handling.

google-labs-jules · 2026-08-03T02:13:02Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

coderabbitai · 2026-08-03T02:13:11Z

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0844ffee-87b9-4f67-b624-155deece7f47

📥 Commits

Reviewing files that changed from the base of the PR and between 4e2eb7f and 53ca2af.

📒 Files selected for processing (1)

frontend/src/components/ProjectsLayout.accessibility.test.tsx

📝 Walkthrough

Walkthrough

The project confirmation button now exposes its submission state with aria-busy. A new accessibility test verifies the initial, pending, and completed states during the confirmation request.

Changes

Project confirmation accessibility

Layer / File(s)	Summary
Confirmation button loading state and coverage `frontend/src/components/ProjectsLayout.tsx`, `frontend/src/components/ProjectsLayout.accessibility.test.tsx`	The confirmation button sets `aria-busy` during submission. The test verifies the button state, text, endpoint call, and completed confirmation state.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

ContextualWisdomLab/naruon#384: Extends the same ProjectsLayout.tsx confirmation-button behavior.
ContextualWisdomLab/naruon#1167: Modifies the confirmation button’s async loading and aria-busy behavior.

Suggested reviewers: opencode-agent

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: adding the aria-busy attribute to the loading confirmation button.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch ux-improvement-disabled-buttons-13634237694443312021

_{Comment @coderabbitai help to get the list of available commands.}

seonghobae · 2026-08-03T02:49:08Z

@coderabbitai review

coderabbitai · 2026-08-03T02:49:13Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

github-actions · 2026-08-03T02:58:13Z

PR governance metadata gate update for 53ca2afac7a7311f895674e2d7a988ac1853d200: no current blocking failures remain.

PR governance metadata gate is ready; all current-head requirements passed.

seonghobae · 2026-08-03T03:07:15Z

@coderabbitai review

Please review current head 15f79be31a60a468637c579ebdd54dc2981263ee, including the loading-button accessibility contract and removal of the repository-local review dispatcher.

coderabbitai · 2026-08-03T03:07:27Z

@seonghobae I will review commit 15f79be31a60a468637c579ebdd54dc2981263ee. I will check the loading-button accessibility contract and the removal of the repository-local review dispatcher.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

seonghobae

Current-head accessibility review completed: the project confirmation control now exposes aria-busy during the async request and a focused jsdom regression test verifies idle, pending, disabled, and completed states. Scope is limited to the component and its test; refresh central review evidence after checks complete.

google-labs-jules · 2026-08-03T03:37:01Z

@coderabbitai review

Please review current head 15f79be31a60a468637c579ebdd54dc2981263ee, including the loading-button accessibility contract and removal of the repository-local review dispatcher.

해당 오류는 내가 마지막으로 작성한 커밋 이후 추가적으로 만들어진 커밋들에서 비롯된 충돌/문제였습니다. 지금 확인해본 결과 CI 체크를 통과할 수 있도록 파일과 변경 사항들이 모두 이미 삭제/수정된 것으로 보입니다. 다른 도움이 필요하다면 알려주세요.

seonghobae

Current head 82ef7a904a5f43df41b7e87f9888dcd64a0e649e is scoped to the production component and its dedicated accessibility regression test. Application CI, security, dependency, Bandit, and Semgrep checks are successful; Docker validation is still completing. Re-triggering current-head OpenCode/merge scheduling.

seonghobae

Commercialization-loop current-head revalidation: 82ef7a904a5f43df41b7e87f9888dcd64a0e649e has zero review threads and all six repository-local workflows, including Docker validation, are successful. Re-triggering the central independent-review and guarded merge scheduler for this exact head.

seonghobae · 2026-08-03T05:45:53Z

@coderabbitai review

Please perform a complete review of the current head 807967e61fc6d0c263eb5693e1a6fd64dce465b1. The branch is refreshed onto current develop, has zero review threads, and changes only ProjectsLayout.tsx plus its dedicated async accessibility regression test.

coderabbitai · 2026-08-03T05:46:03Z

@seonghobae I will perform a complete review of commit 807967e61fc6d0c263eb5693e1a6fd64dce465b1. I will review ProjectsLayout.tsx and the async accessibility regression test.

✅ Action performed

Full review finished.

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 4 minutes.

seonghobae · 2026-08-03T05:52:40Z

@coderabbitai review

The included-review cooldown has elapsed. Please perform the complete current-head review for 807967e61fc6d0c263eb5693e1a6fd64dce465b1 and submit it against that exact commit.

coderabbitai · 2026-08-03T05:52:49Z

@seonghobae I will perform a complete review for commit 807967e61fc6d0c263eb5693e1a6fd64dce465b1. I will review the loading-button accessibility contract and the dedicated async regression test.

✅ Action performed

Full review finished.

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 44 seconds.

seonghobae · 2026-08-03T06:08:20Z

@coderabbitai review

The included-review cooldown is clear now. Please perform the complete review for current head 807967e61fc6d0c263eb5693e1a6fd64dce465b1 and submit the review against that exact commit.

coderabbitai · 2026-08-03T06:08:31Z

@seonghobae I will perform a complete review for commit 807967e61fc6d0c263eb5693e1a6fd64dce465b1 and submit it against that commit.

✅ Action performed

Full review finished.

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 41 minutes.

…94443312021

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@frontend/src/components/ProjectsLayout.accessibility.test.tsx`:
- Around line 108-130: Update the confirmation test around the existing
confirmButton assertions to verify disabled is false before clicking, remains
true while confirmation is pending, and is false or true after completion
according to the component’s disabled={confirmSubmitting || candidateConfirmed}
contract—specifically assert the completed confirmed state is disabled. Keep the
existing aria-busy, text, and API-call assertions unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c00e6f87-affd-4161-8c72-132254b86e33

📥 Commits

Reviewing files that changed from the base of the PR and between 0729be5 and 4e2eb7f.

📒 Files selected for processing (2)

frontend/src/components/ProjectsLayout.accessibility.test.tsx
frontend/src/components/ProjectsLayout.tsx

seonghobae · 2026-08-04T00:30:34Z

Addressed the current review finding in 53ca2afac7a7311f895674e2d7a988ac1853d200: the accessibility regression now asserts the confirmation button is initially enabled, disabled during the pending request, and still disabled after the candidate is confirmed, while retaining all existing aria-busy, message, and API-call checks. Revalidating this exact head before resolving/merging.

google-labs-jules · 2026-08-04T00:31:56Z

Addressed the current review finding in 53ca2afac7a7311f895674e2d7a988ac1853d200: the accessibility regression now asserts the confirmation button is initially enabled, disabled during the pending request, and still disabled after the candidate is confirmed, while retaining all existing aria-busy, message, and API-call checks. Revalidating this exact head before resolving/merging.

확인했습니다. 테스트 변경 사항이 성공적으로 반영된 것을 확인했습니다. 다른 추가 작업이 필요하면 알려주세요.

🎨 Palette: [UX 개선] 비활성화된 로딩 버튼에 aria-busy 속성 추가

5dab65a

seonghobae added 3 commits August 3, 2026 11:23

chore(ci): dispatch stable current-head review evidence

fba4437

chore(ci): remove repo-local review evidence dispatcher

640e853

test(accessibility): cover busy state for project confirmation

15f79be

seonghobae force-pushed the ux-improvement-disabled-buttons-13634237694443312021 branch from 0861a94 to 15f79be Compare August 3, 2026 02:52

chore(scope): restore shared Palette learnings

82ef7a9

seonghobae commented Aug 3, 2026

View reviewed changes

seonghobae marked this pull request as draft August 3, 2026 05:08

seonghobae marked this pull request as ready for review August 3, 2026 05:08

seonghobae commented Aug 3, 2026

View reviewed changes

merge(develop): refresh project loading accessibility branch

807967e

Merge branch 'develop' into ux-improvement-disabled-buttons-136342376…

4e2eb7f

…94443312021

coderabbitai Bot requested changes Aug 3, 2026

View reviewed changes

Comment thread frontend/src/components/ProjectsLayout.accessibility.test.tsx

seonghobae added 2 commits August 4, 2026 08:49

merge(develop): refresh project confirmation accessibility branch

d93a985

test(accessibility): assert confirmation disabled lifecycle

53ca2af

coderabbitai Bot approved these changes Aug 4, 2026

View reviewed changes

seonghobae merged commit c8ef416 into develop Aug 4, 2026
45 checks passed

seonghobae deleted the ux-improvement-disabled-buttons-13634237694443312021 branch August 4, 2026 00:43

Uh oh!

Conversation

seonghobae commented Aug 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

변경 사항

검증 계약

Summary by CodeRabbit

Uh oh!

google-labs-jules Bot commented Aug 3, 2026

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

seonghobae commented Aug 3, 2026

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seonghobae commented Aug 3, 2026

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seonghobae left a comment

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot commented Aug 3, 2026

Uh oh!

seonghobae left a comment

Choose a reason for hiding this comment

Uh oh!

seonghobae left a comment

Choose a reason for hiding this comment

Uh oh!

seonghobae commented Aug 3, 2026

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seonghobae commented Aug 3, 2026

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seonghobae commented Aug 3, 2026

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

seonghobae commented Aug 4, 2026

Uh oh!

google-labs-jules Bot commented Aug 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

seonghobae commented Aug 3, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

github-actions Bot commented Aug 3, 2026 •

edited

Loading

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading