test(ci): align release governance tests with central Security Scan (#926) - #1025
Closed
seonghobae wants to merge 1 commit into
Closed
test(ci): align release governance tests with central Security Scan (#926)#1025seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
…926) Commit #926 intentionally removed this repo's PR-triggered security-scan duplicates because the org-wide central Security Scan already runs dependency-review, scorecard, and trivy-fs on every PR: - deleted .github/workflows/dependency-review.yml - dropped the pull_request: trigger from scorecard.yml and trivy.yml (they now cover the default branch via push/schedule only) The governance suite was not updated in that PR, so two assertions went stale and fail on develop (inherited by every feature PR, e.g. #964/#965/ #970/#971/#972): - test_stepsecurity_remediation_adds_pinned_audit_hardening asserted the now-deleted dependency-review.yml exists and is hardened. - test_required_code_scanning_workflows_upload_scorecard_and_trivy_sarif asserted a pull_request: trigger that was deliberately removed. Realign both tests to the intended architecture: drop the deleted workflow from the hardened list and its dependency-review-action assertion, and assert pull_request: is absent (not present) for scorecard/trivy while keeping the push/develop/master default-branch coverage checks. No governance coverage is lost; the central Security Scan remains the PR gate. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RTAMs4bpSZS77Xe3RQjv9P
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
backend (Python 3.14)CI job fails ondevelop(and therefore on every feature PR that inherits it — #964/#965/#970/#971/#972) with two failures inbackend/tests/test_release_governance.py:Root cause
This is stale test drift, not a Python 3.14 incompatibility (the same assertions fail on any interpreter). Commit
9db32d04(#926, "stop duplicating central Security Scan on PRs") intentionally:.github/workflows/dependency-review.yml, andpull_request:trigger fromscorecard.ymlandtrivy.yml,because the org-wide central Security Scan already runs dependency-review, scorecard, and trivy-fs on every PR. The per-repo workflows now provide default-branch coverage via
push/scheduleonly. The governance suite was not updated in that PR, so two assertions still expect the pre-#926 state.Fix
Realign the governance tests with the intended architecture:
dependency-review.ymlfrom the hardened-workflow list and remove itsdependency-review-actionassertion.pull_request:is absent (not present) for scorecard/trivy, while keeping thepush:/- develop/- masterdefault-branch coverage checks.No governance coverage is lost — the central Security Scan remains the PR gate. Full backend suite verified locally with the CI env (
PYTHONWARNINGS=error,DISABLE_BACKGROUND_WORKERS=1): 1139 passed, 22 skipped (previously 1137 passed, 2 failed).🤖 Generated with Claude Code