Skip to content

test(etl): bind target connector lifecycle logging - #318

Merged
github-actions[bot] merged 4 commits into
developfrom
quality/target-connector-log-confidentiality-feaea5d
Aug 13, 2026
Merged

test(etl): bind target connector lifecycle logging#318
github-actions[bot] merged 4 commits into
developfrom
quality/target-connector-log-confidentiality-feaea5d

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Rebuilds issue #175 from exact protected develop@feaea5d2a353d74919afc9a6971e8c15da5dd2f3 without rewriting stale-base PR #176.

Exact test-only head: 733c1f69e6eed86ddc333b4366142ad07e89e086. The only delta is TargetConnectorLoggingPolicyTest, which binds the two lifecycle failure log calls to finite classification rather than exception-object transport.

Keep Draft until fresh current-head CI proves the intended fail-first boundary. After RED, apply the narrow production change while preserving exception propagation, suppressed cleanup causality, shutdown ordering and connector state. No predecessor-head checks or reviews transfer.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a8d464fc-5b5b-465c-af17-efd8f459fcac

📥 Commits

Reviewing files that changed from the base of the PR and between 8f96517 and 7b898a0.

📒 Files selected for processing (3)
  • etl-service/src/main/java/com/xtrmetl/etl/connector/TargetConnectorDispatcher.java
  • etl-service/src/test/java/com/xtrmetl/etl/connector/TargetConnectorDispatcherLoggingTest.java
  • etl-service/src/test/java/com/xtrmetl/etl/connector/TargetConnectorLoggingPolicyTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 13, 2026 16:19
@github-actions
github-actions Bot merged commit d6c6665 into develop Aug 13, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant