Skip to content

fix(config): rebuild connector alias completeness on live develop - #285

Merged
github-actions[bot] merged 3 commits into
developfrom
repair/connector-alias-completeness-106add
Aug 11, 2026
Merged

fix(config): rebuild connector alias completeness on live develop#285
github-actions[bot] merged 3 commits into
developfrom
repair/connector-alias-completeness-106add

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Replacement execution lane for #257 from exact live develop@106add38465937f6eb4e4accc185fd30aab4446f, preserving the old #258 branch/history without rewriting it.

Current exact head d73099556c4b965bfa46170e4be818e3090f5bac is intentionally test-only RED: it restores the machine-bound connector alias contract against the current protected base and changes no production source. The new assertions require every writable Databricks, Snowflake, and Qlik Sense ConnectorProperties key to be mirrored bidirectionally between mightyetl.* and xtrmetl.*, with modern values winning on overlap.

The old #258 branch diverged only because protected develop advanced by four path-disjoint commits. This replacement does not claim old checks as current-base proof. Keep Draft until hosted fail-first evidence reaches the intended alias boundary; then apply only the bounded production alias-list correction and rerun exact-head validation. Shared literal-source, non-vacuous coverage, dependency-resolution/security, and independent-review gates remain separate.

Summary by CodeRabbit

  • 개선 사항
    • Databricks, Snowflake, Qlik Sense 커넥터의 호스트, 인증, 대상 및 동작 설정에 대해 최신 설정 형식과 기존 설정 형식 간 별칭 지원을 확대했습니다.
    • 기존 설정과 새로운 설정을 함께 사용하는 환경에서도 설정이 양방향으로 호환됩니다.
    • 최신 설정값이 제공된 경우 해당 값이 우선 적용됩니다.
    • 커넥터 설정 전반의 별칭 동작을 검증해 설정 호환성을 강화했습니다.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Databricks, Snowflake, Qlik Sense의 세부 설정 키를 RELATIVE_KEYS에 추가했습니다. 테스트는 setter 기반 허용 키 검증, 양방향 네임스페이스 복사, 현대 설정값 우선 동작을 검증합니다.

Changes

커넥터 설정 별칭

Layer / File(s) Summary
커넥터 별칭 키 확장
etl-service/src/main/java/com/xtrmetl/etl/config/MightyEtlConfigAliasEnvironmentPostProcessor.java
RELATIVE_KEYS에 Databricks, Snowflake, Qlik Sense의 연결, 인증, 대상 및 동작 설정 키를 추가했습니다.
별칭 동작 검증
etl-service/src/test/java/com/xtrmetl/etl/config/MightyEtlConfigAliasEnvironmentPostProcessorTest.java
커넥터 setter에서 허용 키를 생성하고, 양방향 복사와 현대 네임스페이스 값 우선 동작을 검증하는 테스트를 추가했습니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • #257RELATIVE_KEYS 확장과 Databricks, Snowflake, Qlik Sense 설정의 양방향 별칭 및 우선순위 테스트를 다루므로 이 변경과 직접 관련됩니다.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 Databricks, Snowflake, Qlik Sense 커넥터 별칭 범위를 확장하고 완전성을 검증하는 주요 변경 사항을 명확하게 설명합니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch repair/connector-alias-completeness-106add

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 21:18
@seonghobae
seonghobae marked this pull request as draft August 11, 2026 21:42
@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 22:23
@github-actions
github-actions Bot merged commit fe84612 into develop Aug 11, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant