fix(cdc): reject duplicate configured source IDs - #275
Conversation
|
Warning Review limit reached
Next review available in: 22 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #274.
Strict fail-first work from exact protected
develop@942d164ceb7af497bb28a95f842db96429d1bdc4.Exact current test-only head
4def0073a03a80b87086e467b16fdb8732b8e3c8adds onlyCdcSourceFactoryIdentityContractTest. The dedicated test reaches the realCdcSourceFactory.describeConfigured(...)production boundary and requires duplicate configured source IDs to fail closed while repeated connector types under distinct IDs remain valid. Protected source currently validates eachSourceSpeconly in isolation and emits both duplicate rows, so hosted RED must be the focusedassertThrowsfailure after normal compilation and test startup; setup/import/dependency/fixture failure is not valid RED.Keep Draft through hosted RED. After valid RED, the narrow GREEN may touch only
CdcSourceFactory.javaplus this dedicated test unless fresh evidence requires less. Preserve existing source type normalization, repeated connector types under distinct IDs, enabled/disabled reporting, unknown-source classification, current PostgreSQL behavior, active connector discovery work #158/#163, registry identity work #201, canonical docs #149, and shared workflow/POM gates. No predecessor/synthetic evidence transfers.