Skip to content

fix(cdc): reject duplicate configured source IDs - #275

Merged
github-actions[bot] merged 2 commits into
developfrom
integrity/duplicate-configured-source-id-942d164
Aug 11, 2026
Merged

fix(cdc): reject duplicate configured source IDs#275
github-actions[bot] merged 2 commits into
developfrom
integrity/duplicate-configured-source-id-942d164

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Fixes #274.

Strict fail-first work from exact protected develop@942d164ceb7af497bb28a95f842db96429d1bdc4.

Exact current test-only head 4def0073a03a80b87086e467b16fdb8732b8e3c8 adds only CdcSourceFactoryIdentityContractTest. The dedicated test reaches the real CdcSourceFactory.describeConfigured(...) production boundary and requires duplicate configured source IDs to fail closed while repeated connector types under distinct IDs remain valid. Protected source currently validates each SourceSpec only in isolation and emits both duplicate rows, so hosted RED must be the focused assertThrows failure after normal compilation and test startup; setup/import/dependency/fixture failure is not valid RED.

Keep Draft through hosted RED. After valid RED, the narrow GREEN may touch only CdcSourceFactory.java plus this dedicated test unless fresh evidence requires less. Preserve existing source type normalization, repeated connector types under distinct IDs, enabled/disabled reporting, unknown-source classification, current PostgreSQL behavior, active connector discovery work #158/#163, registry identity work #201, canonical docs #149, and shared workflow/POM gates. No predecessor/synthetic evidence transfers.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 22 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 93c5d735-7115-495c-a97a-bc28e51cd958

📥 Commits

Reviewing files that changed from the base of the PR and between 942d164 and 543a89e.

📒 Files selected for processing (2)
  • cdc-service/src/main/java/com/xtrmetl/cdc/spi/CdcSourceFactory.java
  • cdc-service/src/test/java/com/xtrmetl/cdc/spi/CdcSourceFactoryIdentityContractTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 11:20
@github-actions
github-actions Bot merged commit d7054ae into develop Aug 11, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Connector integrity] Reject duplicate configured CDC source IDs

1 participant