fix(cdc): fail closed on blank DDL validation mode - #253
Draft
seonghobae wants to merge 3 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security / data-integrity defect
Protected
develop@942d164ceb7af497bb28a95f842db96429d1bdc4maps a blank or nullxtrmetl.replica.ddl-validation-modetoNONE. BecauseNONEbypasses both allow-list and block-list policy, an explicitly blank configuration can silently disable the documented positive allow-list and admit destructive replicated DDL. Explicitnoneremains a separate intentional opt-out and is not changed by this slice.RCA
DdlValidationMode.from()returnsNONEfor null/blank input;NONEenum mode;nonechoice.TDD state — isolated RED only
Exact current head
735af4f1f66f9b403321a20dcd736adeca001d4ccontains only the focused production-boundary regression test. A transient third assertion against theXtrmetlPropertieswhitelist default was removed because active PR #234 already owns that separate defect.SchemaChangeReplicaValidationModeTestnow has exactly two cases: blank and null validation-mode constructor input must fail closed withIllegalArgumentException.Hosted CI run
31440725288reached the realSchemaChangeReplicaApplierboundary and reproduced exactly those two failures: production threw no exception for either blank or null input. ETL completed successfully first; no setup/import/fixture/dependency failure is being mistaken for RED. The run used GitHub's synthetic merge checkout, so it is causal development evidence rather than literal-source acceptance proof.Writer-lease boundary
Fresh writer inspection found active Draft PR #171 at exact head
977797d133570662f9f9111705100263cd7aee7balso changesSchemaChangeReplicaApplier.javafor DDL diagnostic confidentiality. Its work is unique and must not be raced or overwritten. Therefore this PR remains intentionally test-only RED in the current invocation; the production GREEN is deferred until #171's source lane clears or integrates, after which the defect must be re-read from the then-current protected source before any implementation.No gate is weakened, no central workflow is changed, and no evidence from #171/#234 transfers here. Keep Draft. Before any production mutation or merge, re-resolve the live protected base, exact target source blob and active-writer state, then require a fresh narrow GREEN, literal-source exact-head/current-base CI and security proof, non-vacuous applicable owned-production coverage, complete dependency-scanner evidence, zero valid unresolved findings, and qualifying independent non-author formal approval.