Skip to content

test(cdc): bind bootstrap API and public documentation - #226

Draft
seonghobae wants to merge 2 commits into
developfrom
quality/cdc-bootstrap-docs-tests-622e5e6
Draft

test(cdc): bind bootstrap API and public documentation#226
seonghobae wants to merge 2 commits into
developfrom
quality/cdc-bootstrap-docs-tests-622e5e6

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Advance #225 with a path-disjoint CDC quality slice from exact protected develop@622e5e6c3d534f230c390f10e3832efadfc01825. Protected CdcApplication had the required Spring Boot/discovery/Kafka bootstrap annotations and public entry point but no beginner-readable Javadoc and no focused startup contract.

This Draft changes only CdcApplication and a focused bootstrap test. It does not alter Kafka delivery, CDC lifecycle, replication, registries, configuration values, dependencies, credentials, or active connector capability work.

Exact current identity

  • protected/live base: develop@622e5e6c3d534f230c390f10e3832efadfc01825;
  • branch: quality/cdc-bootstrap-docs-tests-622e5e6;
  • fail-first source head: 496cebe472d71100dcfd075e1ebb7032c4b8e40a;
  • exact current GREEN source head: 1e0eb67d472073f066fba1e3913bc07ea2af6e6f;
  • current synthetic merge preview: d548043cc49c19dd16163eda055a45f004232754;
  • GitHub mergeability: true;
  • Draft: true;
  • formal reviews: none;
  • unresolved review threads: zero.

Every check/review from another source head/base is historical and does not transfer.

RED → GREEN

CdcApplicationContractTest was added before production changed. It preserves @SpringBootApplication, @EnableDiscoveryClient, @EnableKafka, and public-static main(String[]), and requires beginner-readable class/method Javadoc.

Hosted fail-first CI 31371655202, macOS job 93401752811, checked out the RED head merged into exact protected base, completed ETL first, compiled the CDC module and ran 109 CDC tests with exactly one failure, zero errors/skips: CdcApplicationContractTest.publicBootstrapApiHasBeginnerReadableJavadoc. The annotation/main assertions passed. This is valid RED at the intended production/documentation boundary, not setup/import/dependency failure.

Exact current source head 1e0eb67d472073f066fba1e3913bc07ea2af6e6f applies the smallest correction: Javadoc only. It explains standalone mightyETL CDC startup with service discovery and Kafka support during bootstrap and documents main(String[]) plus the Spring Boot argument contract. All bootstrap annotations and SpringApplication.run(...) behavior are unchanged.

Current hosted evidence

All exposed workflow aggregates for this exact current source head are terminal-success:

  • CI 31371876037: success on Ubuntu, macOS and Windows;
  • Dependency Review 31371876077: success;
  • CycloneDX SBOM 31371876153: success;
  • SAST Semgrep 31371876112: success;
  • Security Scan 31371876286: aggregate success.

CI macOS job 93402427375 checked out GitHub synthetic merge d548043cc49c19dd16163eda055a45f004232754, not literal source head. On that tree CdcApplicationContractTest passed 3/3, CDC passed 109/109, ETL passed 275/275 and the full six-module reactor completed BUILD SUCCESS. This is strong merged-tree structural/documentation proof, not literal-source acceptance.

The same CI log reproduces the inherited JaCoCo false-green: Analyzed bundle 'etl-service' with 0 classes followed by coverage success. #162/#164 own selected ETL non-vacuity and #205 owns repository-wide owned-production coverage scope.

Security Scan Trivy job 93402427479 also checked out the same synthetic merge. It printed Dependency version cannot be determined. Child dependencies will not be found. before reporting zero CRITICAL/HIGH/MEDIUM findings, so #196 remains the scanner-completeness authority and the aggregate green is not accepted as complete same-revision Maven vulnerability evidence. It also still observes the tracked 82 MB zipkin.jar, owned by #168/#169.

The current CI merged tree also still exposes raw CDC DDL/row diagnostics from protected base paths; those are already separately owned by #171/#174 and are not duplicated in this bootstrap-only PR.

Scope / merge boundary

Keep Draft. This branch fixes one real public CDC bootstrap documentation/test gap but does not close Kafka/lifecycle/replication issues, #196 scanner completeness, #162/#164 selected non-vacuous coverage, #205 repository-wide coverage, #121/exact-source control dependencies, diagnostic-confidentiality branches, or independent protected review/merge governance. Merge only after the unchanged exact source head satisfies every live applicable gate; no predecessor-head, other-PR, incomplete-scanner, status-only, skipped-required or synthetic-only evidence transfers.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 96572dc7-e2d6-42c0-8255-c48ec8e687fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@opencode-agent opencode-agent Bot added area: api API, protocol, event, or external contract priority: medium Normal-priority or P2 work status: draft Draft pull request type: docs Documentation, ADR, PRD, or technical writing labels Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: api API, protocol, event, or external contract priority: medium Normal-priority or P2 work status: draft Draft pull request type: docs Documentation, ADR, PRD, or technical writing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant