test(cdc): bind bootstrap API and public documentation - #226
Draft
seonghobae wants to merge 2 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Advance #225 with a path-disjoint CDC quality slice from exact protected
develop@622e5e6c3d534f230c390f10e3832efadfc01825. ProtectedCdcApplicationhad the required Spring Boot/discovery/Kafka bootstrap annotations and public entry point but no beginner-readable Javadoc and no focused startup contract.This Draft changes only
CdcApplicationand a focused bootstrap test. It does not alter Kafka delivery, CDC lifecycle, replication, registries, configuration values, dependencies, credentials, or active connector capability work.Exact current identity
develop@622e5e6c3d534f230c390f10e3832efadfc01825;quality/cdc-bootstrap-docs-tests-622e5e6;496cebe472d71100dcfd075e1ebb7032c4b8e40a;1e0eb67d472073f066fba1e3913bc07ea2af6e6f;d548043cc49c19dd16163eda055a45f004232754;Every check/review from another source head/base is historical and does not transfer.
RED → GREEN
CdcApplicationContractTestwas added before production changed. It preserves@SpringBootApplication,@EnableDiscoveryClient,@EnableKafka, and public-staticmain(String[]), and requires beginner-readable class/method Javadoc.Hosted fail-first CI
31371655202, macOS job93401752811, checked out the RED head merged into exact protected base, completed ETL first, compiled the CDC module and ran 109 CDC tests with exactly one failure, zero errors/skips:CdcApplicationContractTest.publicBootstrapApiHasBeginnerReadableJavadoc. The annotation/main assertions passed. This is valid RED at the intended production/documentation boundary, not setup/import/dependency failure.Exact current source head
1e0eb67d472073f066fba1e3913bc07ea2af6e6fapplies the smallest correction: Javadoc only. It explains standalone mightyETL CDC startup with service discovery and Kafka support during bootstrap and documentsmain(String[])plus the Spring Boot argument contract. All bootstrap annotations andSpringApplication.run(...)behavior are unchanged.Current hosted evidence
All exposed workflow aggregates for this exact current source head are terminal-success:
31371876037: success on Ubuntu, macOS and Windows;31371876077: success;31371876153: success;31371876112: success;31371876286: aggregate success.CI macOS job
93402427375checked out GitHub synthetic merged548043cc49c19dd16163eda055a45f004232754, not literal source head. On that treeCdcApplicationContractTestpassed 3/3, CDC passed 109/109, ETL passed 275/275 and the full six-module reactor completedBUILD SUCCESS. This is strong merged-tree structural/documentation proof, not literal-source acceptance.The same CI log reproduces the inherited JaCoCo false-green:
Analyzed bundle 'etl-service' with 0 classesfollowed by coverage success. #162/#164 own selected ETL non-vacuity and #205 owns repository-wide owned-production coverage scope.Security Scan Trivy job
93402427479also checked out the same synthetic merge. It printedDependency version cannot be determined. Child dependencies will not be found.before reporting zero CRITICAL/HIGH/MEDIUM findings, so #196 remains the scanner-completeness authority and the aggregate green is not accepted as complete same-revision Maven vulnerability evidence. It also still observes the tracked 82 MBzipkin.jar, owned by #168/#169.The current CI merged tree also still exposes raw CDC DDL/row diagnostics from protected base paths; those are already separately owned by #171/#174 and are not duplicated in this bootstrap-only PR.
Scope / merge boundary
Keep Draft. This branch fixes one real public CDC bootstrap documentation/test gap but does not close Kafka/lifecycle/replication issues, #196 scanner completeness, #162/#164 selected non-vacuous coverage, #205 repository-wide coverage, #121/exact-source control dependencies, diagnostic-confidentiality branches, or independent protected review/merge governance. Merge only after the unchanged exact source head satisfies every live applicable gate; no predecessor-head, other-PR, incomplete-scanner, status-only, skipped-required or synthetic-only evidence transfers.