Skip to content

feat(integration): add concrete PostgreSQL plugin runtime - #245

Draft
seonghobae wants to merge 125 commits into
feat/plugin-vault-hosted-runtime-v1from
feat/plugin-vault-postgres-driver-v1
Draft

feat(integration): add concrete PostgreSQL plugin runtime#245
seonghobae wants to merge 125 commits into
feat/plugin-vault-hosted-runtime-v1from
feat/plugin-vault-postgres-driver-v1

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Buyer/security outcome

Advances #130/#244 from an abstract hosted PostgreSQL seam to an Integration-owned node-postgres/default-entrypoint implementation without borrowing another bounded context's Pool, using generic DATABASE_URL, or treating process-wide PostgreSQL settings as authority.

Current non-force ancestry

Parent #244 remains f0b91869f306b1b7d0d5759307acf347e413aa06. Current exact #245 head is workflow-free 39ebec99d907356a99a1a15528a3a1df713472ed, open Draft/mergeable and ahead-only of #244. No force update, destructive rebase, source copy, cross-service SQL, mutable dependency, bypass, or self-approval is used.

Preserved credential and real-environment authority

Credential replay requires exact provider-backed secret evidence and revalidates both owning installation authority and exact durable credential-binding authority after provider I/O. Hosted RED fecaf9882b9737cb5e14a6e4eeeb96b8d37c270a → repair e3508eb504d67c7d56b6946a432ef0f99726c9a1 closes concurrent credential-revocation replay. Hosted run 34162364466 passed focused replay, Plugin SDK build, Integration typecheck and the complete Integration suite.

Exact ancestor 21b5c206decf1ca6a9b337811a56bddce39ff730 completed run 34166380591 against real Vault KV v2 plus migrated Integration-owned PostgreSQL across installation → credential create → exact replay → installation revocation fence → runtime restart → credential revocation → idempotent cleanup. Plaintext provider material stays behind the Vault adapter and never becomes durable LifeOS metadata.

PostgreSQL-enabled complete-suite RED → repair → GREEN

#252 verifier run 34193116872, job 101955068900, exposed three inherited #245 test-expectation defects after the #252-owned focused/typecheck gates passed: two tests treated explicit undefined as malformed despite intentional JavaScript default-parameter semantics, and the delivery-origin migration test expected the old FK name although migration 0004 now rejects the foreign-installation fixture first at plugin_delivery_origin_active_installation_check.

Purpose run 34195380880, job 101961833554, executed exact owner-repair head 994dcd8f4e01a26dad0a199b81faa7dc08d6167c on a real ubuntu-24.04 runner and completed success. It proved the three current failures under PostgreSQL, applied only the expectation repair, committed the exact candidate, passed focused PostgreSQL tests, Integration typecheck and the complete PostgreSQL-enabled Integration suite, then ordinary-pushed the verified descendant and removed its own write-capable workflow. The retained result is current head 39ebec99...; compare from the prior retained #245 head c94caf3f6e468a59ab1ab3b7b7ffd51b6e9a8f7e contains only the three repaired test files.

Current #130 successors

#250 has non-force adopted this parent at 2fef9decf5053c7abf2443ec8e5cae4278e7baac; parent→child compare remains ahead-only with behind_by=0 and exactly its six existing operator/composition paths. #251 has in turn non-force adopted #250 at 5067f870bdaa9a026411298a2233d4d053708b5a; its parent→child compare remains ahead-only with behind_by=0 and exactly the existing three HTTP/raw-route paths.

#252 remains an independent direct child of this exact #245 parent and has now completed its durable-attempt admission semantic/review-repair proof. Dependency-rejection RED proof head 987f0a8ca1ffb132146eee784bf3a3f281801f58, run 34202494161, job 101984290407, failed exactly the intended raw dependency-error cases; minimum repair c6330c06b6372b2bcdbebf08b16e51a4339d300a then passed exact run 34203636724, job 101987958062. Four subsequent valid review repairs were replayed from their RED ancestors and exact proof head 9e6e88e49e14d0b2d247e747df968e2494697666 passed run 34209314512, job 102006262067, across canonical formatting/diff hygiene, focused delivery-attempt acceptance, Integration typecheck and the complete Integration suite. All four review threads are resolved. Current #252 head cbb3caaddf3ad8d84ef27a6c7ba9aa624bed972a differs from that proven head only by removal of its purpose-complete verifier.

Neither #250, #251 nor #252 grants outbound network authority. A later network executor must consume a released/versioned canonical egress contract for DNS/IP/redirect/proxy/connect-time SSRF controls and preserve bounded I/O, retry/outcome, revocation, recovery and operator evidence. Durable origin identity and durable attempt identity are not connect-time network authorization.

Acceptance boundary

Keep Draft until the stack satisfies current repository/security/review authority and integrates through normal protected policy. Ancestor semantic GREEN is not unchanged-head protected-branch merge authority. No administrator bypass is used.

Refs #130, #205, #235, #241, #242, #243, #244, #250, #251, #252; brianc/node-postgres#2263; ContextualWisdomLab/.github#712.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f0ad16f1-8111-4df7-b511-b1ce7ad575c3

📥 Commits

Reviewing files that changed from the base of the PR and between f0b9186 and 39ebec9.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (31)
  • ARCHITECTURE.md
  • CHANGELOG.md
  • apps/integration-service/package.json
  • apps/integration-service/src/plugin-credential-clock-evidence.test.ts
  • apps/integration-service/src/plugin-credential-durable-record.test.ts
  • apps/integration-service/src/plugin-credential-lifecycle-authority.test.ts
  • apps/integration-service/src/plugin-credential-malformed-authority.test.ts
  • apps/integration-service/src/plugin-credential-malformed-read-evidence.test.ts
  • apps/integration-service/src/plugin-credential-replay-secret.test.ts
  • apps/integration-service/src/plugin-credential-repository-invalid-evidence.test.ts
  • apps/integration-service/src/plugin-credential-revocation-winner-consistency.test.ts
  • apps/integration-service/src/plugin-credential.test.ts
  • apps/integration-service/src/plugin-credential.ts
  • apps/integration-service/src/plugin-delivery-origin-migration.integration.test.ts
  • apps/integration-service/src/plugin-operator-http-authority.integration.test.ts
  • apps/integration-service/src/plugin-vault-hosted-bootstrap.test.ts
  • apps/integration-service/src/plugin-vault-hosted-runtime.test.ts
  • apps/integration-service/src/plugin-vault-postgres-driver-acquisition-boundary.test.ts
  • apps/integration-service/src/plugin-vault-postgres-driver-ip-authority.test.ts
  • apps/integration-service/src/plugin-vault-postgres-driver-logger-boundary.test.ts
  • apps/integration-service/src/plugin-vault-postgres-driver-method-capture.test.ts
  • apps/integration-service/src/plugin-vault-postgres-driver-postgres.integration.test.ts
  • apps/integration-service/src/plugin-vault-postgres-driver.test.ts
  • apps/integration-service/src/plugin-vault-postgres-driver.ts
  • apps/integration-service/src/plugin-vault-postgres-vault.integration.test.ts
  • apps/integration-service/src/plugin-vault-secret-store-body-cleanup.test.ts
  • apps/integration-service/src/plugin-vault-secret-store-verification.test.ts
  • apps/integration-service/src/plugin-vault-secret-store.ts
  • apps/integration-service/src/server.test.ts
  • apps/integration-service/src/server.ts
  • docs/operations/plugin-vault-postgres-acceptance.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant