feat(web): add authenticated goal creation BFF - #214
Draft
seonghobae wants to merge 16 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Advances #209 with one bounded first-party authenticated Goal browser boundary. The web BFF authenticates through Identity, derives workspace authority server-side, signs the exact Planning method/path, forwards no browser credential to Planning, validates returned ownership/schema evidence, rejects duplicate/oversized collections, and exposes only browser-safe Goal evidence.
The feature history remains test-first and retains the media-type and duplicate-identity regressions. This slice does not add the Goals workspace UI and does not close #209.
Protected-main adoption
Protected
mainis193a87ef54c3fe6dcda4755bce4d6bc81e3a0297. Current exact #214 headdf958511364ecc50716ebf1bf4445a29738f6bdbis an ahead-only non-force descendant whose merge base is that protected main. The feature delta remains exactly five Goal-BFF paths. The dependent buyer-path stack was previously restacked non-destructively through Weekly Review; no child delta was rewritten or dropped.Fresh exact-head evidence and foundation finding
The six repository workflows for
df958511...are terminal:34111043740: GREEN.34111043749: GREEN.34111043811: GREEN.34111043732: RED only invalidate;today-concurrency,compose_runtime,browser-acceptance, andmerge_compatibilityare GREEN. Thevalidatejob checked out exactdf958511..., completed setup/frozen install, then failed at rootpnpm format:checkbefore lint/typecheck/test/build.34111043773: RED in Trivy FS after exact-head checkout and successful scan/SARIF production; OSV and Scorecard are GREEN. This branch does not own the shared vulnerable package graph.34111043847: RED in the central asynchronous CodeQL compatibility protocol; dispatch itself completed successfully. This remains central owner authority rather than a reason to alter Goal BFF source.Fresh causal inspection still places both repository-level REDs outside this five-file Goal slice. Root formatting/package/security authority is owned by protected-main-based #249, not by the buyer-path leaf. #249 has since advanced beyond its earlier
qs-only state: current exact4aed8e66a95dd0b43c86849cf023294addd5e9abpreserves root-only AppGuardrail Markdown semantics and is repairing the sharedqs,multer, retained Next 15.5, andsharpdependency graph under exactpnpm@10.15.0regeneration. Its current package repair workflow has already proved regeneration and structural patched-resolution checks and is now executing the canonical PostgreSQL-backed full repository contract suite; that current head is not yet GREEN and no package candidate is claimed published.Therefore #214 must not copy a root override, package lock, scanner suppression, or temporary repair workflow. After #249 integrates normally, #214 must adopt the resulting protected foundation through an ordinary non-force descendant, preserve its five-file Goal delta, and reacquire exact-head repository/security/review evidence.
Review and merge boundary
Submitted independent reviews are still absent. Keep Draft until #249 integrates normally, #214 adopts the resulting protected main non-destructively, and the unchanged descendant reacquires terminal repository/central checks plus current independent review/thread authority. No self-approval, administrator bypass, force-push, destructive rebase, stale evidence reuse, scanner suppression, or gate weakening is used.