Skip to content

fix(calendar): compensate secrets on mismatched create evidence - #201

Merged
seonghobae merged 4 commits into
mainfrom
fix/calendar-create-evidence-compensation
Aug 12, 2026
Merged

fix(calendar): compensate secrets on mismatched create evidence#201
seonghobae merged 4 commits into
mainfrom
fix/calendar-create-evidence-compensation

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Security/reliability outcome

Calendar connection creation already compensates newly materialized provider credentials when metadata persistence throws, but current protected main does not compensate when persistence returns durable evidence that fails exact connection/workspace/user/secret-handle validation. That fail-closed path can leave newly written credential material orphaned in the external secret store.

Test-first state

Commit 1222a34bbece965562e488fea6fe567f1089684d adds a regression requiring both newly stored credential handles to be deleted when returned durable metadata has a mismatched connection identity. This commit is intentionally RED against the current implementation.

Acceptance

  • validate returned durable evidence against exact trusted authority and newly written handles;
  • on validation/evidence mismatch, compensate all newly written credentials in reverse order before returning the existing credential-free dependency error;
  • if compensation cannot be proven, remain fail-closed without exposing secret material;
  • preserve successful create behavior and existing persistence/KMS failure compensation;
  • exact-head package/full CI, security, automated review and live-base compatibility must pass before merge.

Advances #129 without claiming the full hosted credential lifecycle complete.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e9750f33-a768-4002-8cfa-3c81a97eb802

📥 Commits

Reviewing files that changed from the base of the PR and between 7c3fd32 and beeb626.

📒 Files selected for processing (2)
  • apps/integration-calendar-service/src/calendar-connection-create.test.ts
  • apps/integration-calendar-service/src/calendar-connection-create.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 12, 2026 11:41
@seonghobae
seonghobae merged commit 4bd155d into main Aug 12, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant