fix(calendar): compensate secrets on mismatched create evidence - #201
Conversation
|
Warning Review limit reached
Next review available in: 5 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Security/reliability outcome
Calendar connection creation already compensates newly materialized provider credentials when metadata persistence throws, but current protected main does not compensate when persistence returns durable evidence that fails exact connection/workspace/user/secret-handle validation. That fail-closed path can leave newly written credential material orphaned in the external secret store.
Test-first state
Commit
1222a34bbece965562e488fea6fe567f1089684dadds a regression requiring both newly stored credential handles to be deleted when returned durable metadata has a mismatched connection identity. This commit is intentionally RED against the current implementation.Acceptance
Advances #129 without claiming the full hosted credential lifecycle complete.