Skip to content

feat(habit): add data-rights contributor v1 - #184

Merged
seonghobae merged 8 commits into
mainfrom
feat/habit-data-rights-contributor-v1
Aug 10, 2026
Merged

feat(habit): add data-rights contributor v1#184
seonghobae merged 8 commits into
mainfrom
feat/habit-data-rights-contributor-v1

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Outcome

Advance #55 with the next independently deployable service-owned contributor after protected Planning #179. This slice is intentionally limited to Habit-owned persistence and consumes the already-protected life-os.data-rights-contributor.v1 lifecycle. Identity remains the orchestration authority; there is no cross-service SQL access.

Test-first state

The first commit is a deliberate RED contract: the production Habit runtime must expose a service-owned contributor that returns an empty deterministic export for an empty workspace. The branch must prove that failure comes from the missing runtime contributor, then add the smallest transactional Habit-owned implementation and PostgreSQL evidence.

Required semantics

  • exact UUIDv4 workspace/user/request/idempotency boundaries;
  • deterministic stable Habit definition/completion export with schema version, count, and SHA-256 evidence;
  • separately authorized Habit erasure path that preserves normal append-only completion-history enforcement while allowing explicit data-rights erasure only through the owning service;
  • replay-safe durable erasure receipts, fail-closed preflight, and post-erasure verification;
  • realistic multi-tenant PostgreSQL integration evidence;
  • runtime composition and beginner-readable public docstrings.

Merge gate

Keep Draft until RED -> GREEN implementation is complete and the unchanged exact head passes current CI, AppGuardrail, SAST Semgrep, Security Scan, Commercial Readiness, CodeRabbit/current automated review, package tests/typecheck/build, real PostgreSQL evidence, and current-live-base compatibility. No administrative bypass or stale evidence.

Refs #55, #21.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 6 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e69123c6-1a3d-4489-b518-217aa9d6b637

📥 Commits

Reviewing files that changed from the base of the PR and between 3e3c8b0 and 359dabd.

📒 Files selected for processing (6)
  • apps/habit-service/migrations/0002_data_rights_erasure.sql
  • apps/habit-service/src/habit-data-rights.integration.test.ts
  • apps/habit-service/src/habit-data-rights.test.ts
  • apps/habit-service/src/habit-data-rights.ts
  • apps/habit-service/src/habit-runtime.test.ts
  • apps/habit-service/src/habit-runtime.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 10, 2026 22:02
@seonghobae
seonghobae merged commit 81956f6 into main Aug 10, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant