fix(plugin): bind durable installation replay to opaque identity

[seonghobae]

Security/data-integrity outcome

Fail closed whenever a PluginInstallationStore returns durable evidence for a different opaque installation identity. Workspace, installer, manifest digest and grant equality are not sufficient if installationId itself changed, and a lookup for one opaque locator must never expose a different durable row.

Test-first sequence

1. plugin-installation-evidence-identity.test.ts introduces a persistence-double regression that returns an otherwise identical create/replay winner with a different UUIDv4 installation ID. Against protected main 5fdb8ee899991cbfd27c41ce59079648829b2a30, PluginInstallationApplication.install() would accept it because sameInstallation() did not compare the opaque ID.
2. Production code adds exact installationId equality to sameInstallation().
3. plugin-installation-lookup-evidence-identity.test.ts independently returns a different opaque ID from findById() while preserving workspace/user authority. Protected main would expose that row because the application verified only workspace and installer.
4. Production lookup now requires the durable installationId to equal the requested locator before returning it.

The PostgreSQL store already validates these identities. The application-level checks keep alternate/future persistence adapters from silently widening the trust boundary.

Scope

Three-file integrity hardening only. No schema, public API, capability, secret-store or outbound-network behavior changes.

Verification

Require unchanged exact head b200fcf44ad2987e5d13d25d2bfdcf8cf92b4108 to pass integration-service tests/typecheck/build, configured coverage/docstring gates, CI, AppGuardrail, SAST Semgrep, Security Scan, Commercial Readiness and all current review findings before merge. No predecessor evidence transfers.

Refs #130.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 seconds

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 32a4d2d5-0a43-40c7-bb04-8d0acd8493b3

📥 Commits

Reviewing files that changed from the base of the PR and between 5fdb8ee and b200fcf.

📒 Files selected for processing (3)

• apps/integration-service/src/plugin-installation-evidence-identity.test.ts
• apps/integration-service/src/plugin-installation-lookup-evidence-identity.test.ts
• apps/integration-service/src/plugin-installation.ts

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/plugin-installation-evidence-identity

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.