Skip to content

test(identity): isolate data-rights ledger database fixture - #170

Merged
github-actions[bot] merged 2 commits into
mainfrom
fix/data-rights-ledger-test-isolation
Aug 10, 2026
Merged

test(identity): isolate data-rights ledger database fixture#170
github-actions[bot] merged 2 commits into
mainfrom
fix/data-rights-ledger-test-isolation

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Reliability outcome

Make the data-rights request-ledger PostgreSQL fixture safe under concurrent/full-repository verification instead of force-terminating clients in the shared CI server.

Observed RED

PR #169 exact-source validation passed after its plugin migration fix, but live-base merge compatibility failed in the unrelated identity-service suite with PostgreSQL 57P01 (terminating connection due to administrator command) from data-rights-request-ledger.integration.test.ts. The fixture currently executes DROP DATABASE ... WITH (FORCE) around a fixed test database, which can kill active clients rather than serialize ownership.

This branch starts with a regression contract that rejects force-terminating teardown and requires advisory-lock ownership. The next commit will implement the smallest fixture-only repair, following the already protected session-migration isolation pattern.

Scope

Test harness only. No product persistence, data-rights semantics, migrations, API contracts, or production runtime behavior change.

Acceptance

Observe the regression RED first, then replace force termination with one session-scoped advisory lock, close the test pool before database drop, release the lock in cleanup, and prove exact-head Identity/full CI plus live-base merge compatibility without weakening any gate.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 826372a2-a29a-41c4-89af-d66b49adb66d

📥 Commits

Reviewing files that changed from the base of the PR and between 0d8c86e and 3bf5e7b.

📒 Files selected for processing (2)
  • apps/identity-service/src/data-rights-request-ledger-fixture.test.ts
  • apps/identity-service/src/data-rights-request-ledger.integration.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 10, 2026 06:14
@github-actions
github-actions Bot merged commit b69731c into main Aug 10, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant