feat: add explicit xAPI protocol binding - #7
Open
seonghobae wants to merge 8 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer outcome
Give ContextualWisdomLab learning products one reusable fail-closed contract for selecting canonical xAPI 2.0 versus explicit cmi5 Quartz/xAPI 1.0.3 compatibility, without silently rewriting historical records or moving xAPI statement truth into this shared contract repository.
Product boundary
agent/bootstrap-learning-contracts);cwl_xapi_protocol_binding/v1with immutable logical identity;xapi_2_0requires xAPI2.0.0and the adoptedISO/IEC/IEEE 39274-1-1:2025authority;cmi5_quartzrequires xAPI1.0.3, Quartz 1st Edition and pinned revision984a9b8;Test-first evidence
05bbb0936c4ecfb87b7400d73545722ca1137ec7introduced the executable regression contract before the schema/fixtures existed.2bbb549f5dda58794af4979f9f15ae3f514e4249added the schema plus two valid and four invalid fixtures.6334e925050c562e27cee0857fb37c85ee36bea0runs the regression suite in Learning Contracts Quality.b90103ecdc0f6e31edbb957d18b308d1f521d267makes repository Quality run for feature-branch bases instead of onlydevelop/main; the reusable trigger fix was also propagated to bootstrap PR docs: bootstrap learning interoperability contracts #1.c3efe18ebd6f6411d5dc99efb8752dafa4e2de46.64b3a8ab2445801cb24ac559bcdb0befda95e338is a non-destructive merge commit absorbing the current bootstrap writer head instead of rebasing/force-pushing.036d2a868c8bd4cfc823183835cc1bda5259f78aremoves premature standards implementation claims and explicitly records that requirement-level evidence plus terminal-success exact-head CI are still absent; the corresponding Devin thread became outdated and was resolved only after that exact-head change.Architecture and standards discipline
ADR 0002 defines
ProtocolBindingas a reusable value object in the Learning Contract Authority bounded context and an anti-corruption boundary before consumer-owned version-specific adapters. Learning Record Store/runtime repositories retain statement/session/persistence authority. Standards traceability deliberately distinguishes the internal binding candidate from full implementation/conformance. Current authoritative evidence identifies ISO/IEC/IEEE 39274-1-1:2025 as the published xAPI standard, AICC Quartz revision984a9b8as the cmi5 compatibility source used here, and IEEE P9274.3.1 as an active project authorization rather than an approved cmi5 standard.Exact-head state
Current exact head:
036d2a868c8bd4cfc823183835cc1bda5259f78a.Current base:
agent/bootstrap-learning-contracts@65561221d9210884d234e52edc3e023e93d3278d.The PR is open, Ready and mechanically mergeable after absorbing the parent update. The current repository Quality run is
33556210577; job100017549525is queued with no executed steps at the latest read, so no predecessor run is promoted to current-head evidence. The prior actionable review thread is resolved after the traceability claim was corrected; independent approval is still absent.This PR remains intentionally stacked so issue #3 can advance while parent exact-head checks/review are pending. After PR #1 integrates into protected
develop, this diff must be retargeted/restacked and reverified through the ordinary protected path before merge. No self-approval, bypass, force-push, or governance weakening is requested.Partial implementation of #3.