ci(actions): reduce pull request queue fan-out - #401
Conversation
Signed-off-by: Seongho Bae <me@seonghobae.me>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughCI와 릴리스 워크플로의 동시성 그룹 식별자를 저장소별로 구분합니다. Pull request에서는 Python 3.14만 테스트하고, 다른 이벤트에서는 Python 3.11~3.14를 테스트합니다. 관련 설정을 계약 테스트로 검증합니다. Changes워크플로 실행 정책
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change scopes CI cancellation to the same repository and PR, reduces PR testing to Python 3.14, and preserves the full Python matrix for protected main pushes. Release runs remain non-cancelling and independently grouped; no current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 098771a999
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.11", "3.12", "3.13", "3.14"] | ||
| python-version: ${{ github.event_name == 'pull_request' && fromJSON('["3.14"]') || fromJSON('["3.11", "3.12", "3.13", "3.14"]') }} |
There was a problem hiding this comment.
On pull requests this now runs Office verification only on Python 3.14, but the canonical verification guidance still says CI executes the complete 3.11–3.14 matrix (office/README.md:273-275) and that normal exact-head CI retains those gates (docs/print-output.md:46). Because the new test treats this PR/main split as a durable workflow contract, update the smallest affected canonical test-strategy or verification documentation to make clear that compatibility failures on 3.11–3.13 are detected only after merge.
AGENTS.md reference: AGENTS.md:L5-L9
Useful? React with 👍 / 👎.
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.11", "3.12", "3.13", "3.14"] | ||
| python-version: ${{ github.event_name == 'pull_request' && fromJSON('["3.14"]') || fromJSON('["3.11", "3.12", "3.13", "3.14"]') }} |
There was a problem hiding this comment.
With this expression in place, every Office job fails its own coverage run -m pytest: office/tests/test_python_support_contract.py:53-56 requires python-version to be followed directly by a literal YAML list, so it cannot match this ${{ ... }} value and fails at assert matrix_match is not None. Update that contract test to validate the event-dependent PR/main matrices before switching the workflow representation.
AGENTS.md reference: AGENTS.md:L5-L9
Useful? React with 👍 / 👎.
1 participant
변경 내용
workflow-repository-PR단위로 고정해 같은 PR의 이전 실행만 취소합니다.mainpush에서는 3.11–3.14 호환성 검증을 모두 유지합니다.cancel-in-progress: false를 유지합니다.Performance Evidencequeued run 1개만 취소했습니다. release/build/deploy/publish 계열은 취소하지 않았습니다.검증
Base:
720a87fd2155c532e6326dee767bb4b9e5e4d5fcHead:
098771a999f4ff6e7d2bb541047bc4512039e2ecactionlint .github/workflows/*.ymlcorepack pnpm exec vitest run src/workflowExactHead.test.ts src/releaseWorkflowSyntax.test.ts src/releaseExactCheckout.test.ts— 13 passedcorepack pnpm typecheckgit diff --check제품 코드는 변경하지 않았습니다. protected merge는 요청하지 않습니다.
Summary by CodeRabbit
개선 사항
테스트