chore: ignore external agent-runtime scratch registries - #393
Conversation
An external contextual-orchestrator agent runtime writes registered_agents.json and task_agent_mapping.json into whatever directory it is invoked from. When run against this checkout they surface as untracked files that any concurrent writer could commit by accident. They are not Inkspan source, contracts, or evidence, so ignore them at the repository root. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RCDAt2v7kz4SFyaFDsSoyD
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Changes작업 트리 무시 규칙
Estimated code review effort: 1 (매우 낮음) | ~2분 Merge Risk: ⚪ Minimal · up to The change scopes the two scratch-registry ignore rules to repository-root files only, preserving nested files with matching names. No current merge-readiness risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.
Findings
1. HIGH Current-head GitHub Checks - Fix failed required checks before approval
- Problem: Failed same-head checks remain for
cb40d62c89cf7bc58e0bc2c365e3549c044ec285. - Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
- Fix: Read and fix the failed check logs below, then rerun the current-head checks.
- Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.
Failed checks:
- Required Noema Review/noema-review: FAILURE (https://github.com/ContextualWisdomLab/inkspan/actions/runs/33390229461/job/99481925590)
- Security Scan/dependency-review: FAILURE (https://github.com/ContextualWisdomLab/inkspan/actions/runs/33390230141/job/99481927820)
- dependency-review check run: failure (https://github.com/ContextualWisdomLab/inkspan/actions/runs/33390230141/job/99481927820)
- noema-review check run: failure (https://github.com/ContextualWisdomLab/inkspan/actions/runs/33390229461/job/99481925590)
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Repository file: .gitignore"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Repository file: .gitignore"]
R1 --> V1["required checks"]
OpenCode Review Overview
|
|
@codex review\n\nPlease review exact current head |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The outstanding CHANGES_REQUESTED review is bound to predecessor head cb40d62, not the current head. Fresh hosted evidence:
No code change can remediate predecessor-head failures. Please review the exact current head once its queued Checks receive runners. @codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Current-head Office failure is inherited from protected main and is not caused by this
The failing support-contract parser expects a static Python matrix while protected main now uses an event-dependent matrix. Do not duplicate #405 here. Revalidate #393 on a protected descendant after #405 integrates; earlier checks and reviews do not transfer. |
![cwl-noema-review[bot]](https://avatars.githubusercontent.com/u/295022177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Noema LLM review
PR #393 appends two ignore entries for external contextual-orchestrator scratch registries to .gitignore. The patterns are specific, documented as non-source artifacts, and no tracked files with these names exist; no security, maintainability, or regression concerns identified.
Reviewed changed lines
.gitignore:29 (RIGHT): Comment line introduces a dedicated section for external agent-runtime scratch registries. Clear and consistent with the existing .gitignore organization..gitignore:30 (RIGHT): Comment continuation accurately scopes the purpose of the following ignore entries..gitignore:31 (RIGHT): Comment clarifies these entries are not Inkspan source or contracts, providing useful maintainability context..gitignore:32 (RIGHT): Ignore pattern 'registered_agents.json' is specific and no tracked file with this name exists in the repository; it does not impact version-controlled content..gitignore:33 (RIGHT): Ignore pattern 'task_agent_mapping.json' is specific and no tracked file with this name exists in the repository; it does not impact version-controlled content..gitignore:34 (RIGHT): Empty line separates the new section from existing content, preserving file structure.
Adversarial validation
.gitignore:32 (RIGHT)falsified: A legitimate tracked file named 'registered_agents.json' could be inadvertently ignored and removed from version control. — Repository context shows no tracked file named 'registered_agents.json'. The ignore pattern is documented specifically as targeting external runtime scratch registries, and no version-controlled content with this name exists..gitignore:33 (RIGHT)falsified: A legitimate tracked file named 'task_agent_mapping.json' could be inadvertently ignored and removed from version control. — Repository context shows no tracked file named 'task_agent_mapping.json'. The ignore pattern is documented specifically as targeting external runtime scratch registries, and no version-controlled content with this name exists.- Residual risk: Minimal. Patterns are unanchored and therefore match files anywhere in the repository, so a future legitimate source file with one of these exact names could be unintentionally ignored. Given the highly specific names and documented purpose as external runtime scratch registries, collision probability is very low.
Findings
- No blocking findings.
- Result: APPROVE
- Head SHA:
8818c4d31801190de34f8b9cb1d5993257249d3c - Reviewer credential:
noema-review-github-app-refresh - Actor:
cwl-noema-review[bot]
seonghobae
added
maintenance
priority: medium
ChatGPT Codex Connector
Preserve nested source and fixture files with the same names while ignoring the two external runtime registries at the checkout root. Co-Authored-By: Codex <noreply@openai.com> Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Fixed the remaining ignore-scope mismatch in The PR describes checkout-root scratch files, but the two unanchored patterns also hid nested source/fixture files. Both patterns now start with Native Git RED → GREEN check:
This is a new head, so predecessor approvals/checks do not transfer. The earlier Office support-contract failure remains owned by #405; no duplicate repair, self-approval, or merge bypass was added here. |
1 participant
Summary
An external
contextual-orchestratoragent runtime writesregistered_agents.jsonand
task_agent_mapping.jsoninto whatever directory it is invoked from. When itruns against an Inkspan checkout, those two files (typically just
{}) appear asuntracked entries that any concurrent writer could
git add .by accident.They are not Inkspan source, contracts, or evidence. This change ignores them at
the repository root and documents why.
Scope
.gitignoreonly. No source, dependency, workflow, or contract change.is affected.
Verification
git check-ignore registered_agents.json task_agent_mapping.jsonnow matches.git statusis clean in a checkout where the agent runtime has run.🤖 Generated with Claude Code
Summary by CodeRabbit