Repository navigation
fix(security): raise transitive dependency floors #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
724b45b
fix(security): raise transitive dependency floors
seonghobae 868b88f
test(security): define pnpm supply-chain policy
seonghobae 1e1fd96
test(security): run pnpm supply-chain policy contract
seonghobae b70fb18
fix(security): enforce pnpm supply-chain policy
seonghobae 114315b
test(security): bound legacy trust-policy compatibility
seonghobae 735d618
fix(security): bound legacy trust-policy compatibility
seonghobae 235535d
test(security): move pnpm policy contract into canonical suite
seonghobae 637a1c5
fix(ownership): release package manifest writer
seonghobae 244e205
fix(ownership): keep security contract in canonical suite
seonghobae 93fab95
test(security): avoid dynamic regexp in policy parser
seonghobae 905b291
test(security): reject duplicate workspace policy scalars
seonghobae 6954201
fix(security): fail closed on duplicate workspace policy keys
seonghobae b666460
test(package): reject symlinked consumer resolution escapes
seonghobae 4a39d8a
fix(package): canonicalize consumer resolution paths
seonghobae 522200a
test(package): execute symlink escape validators
seonghobae 41f9788
fix(package): validate paths before loading consumers
seonghobae 3b5446a
test(package): pin validated runtime entry loading
seonghobae c2db417
fix(package): load validated canonical runtime entries
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import { readFileSync } from 'node:fs'; | ||
| import { dirname, join } from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| const repositoryRoot = join(dirname(fileURLToPath(import.meta.url)), '..'); | ||
| const workspacePolicy = readFileSync( | ||
| join(repositoryRoot, 'pnpm-workspace.yaml'), | ||
| 'utf8', | ||
| ); | ||
| const workspacePolicyLines = workspacePolicy.split(/\r?\n/u); | ||
|
|
||
| function readScalar( | ||
| name: string, | ||
| lines: readonly string[] = workspacePolicyLines, | ||
| ): string | undefined { | ||
| const prefix = `${name}:`; | ||
| const matches = lines.filter((candidate) => candidate.startsWith(prefix)); | ||
| if (matches.length !== 1) return undefined; | ||
| return matches[0]?.slice(prefix.length).split('#', 1)[0]?.trim(); | ||
| } | ||
|
|
||
| describe('pnpm supply-chain policy', () => { | ||
| it('pins security-sensitive install policy instead of relying on mutable defaults', () => { | ||
| expect(readScalar('blockExoticSubdeps')).toBe('true'); | ||
| expect(readScalar('minimumReleaseAge')).toBe('10080'); | ||
| expect(readScalar('trustPolicy')).toBe('no-downgrade'); | ||
| expect(readScalar('trustPolicyIgnoreAfter')).toBe('43200'); | ||
| }); | ||
|
|
||
| it('rejects duplicate root policy scalars instead of accepting the first declaration', () => { | ||
| expect( | ||
| readScalar('trustPolicy', [ | ||
| 'trustPolicy: no-downgrade', | ||
| 'trustPolicy: always', | ||
| ]), | ||
| ).toBeUndefined(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.