Skip to content

ci: run setup-node natively on Node 24 #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 3 commits into from
Aug 10, 2026
Merged

ci: run setup-node natively on Node 24 #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a916ec7
test(ci): require native Node 24 setup-node
seonghobae Aug 10, 2026
c32897e
test(ci): track current setup-node v7 release
seonghobae Aug 10, 2026
7631c4d
ci: use native Node 24 setup-node
seonghobae Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
# (pnpm 10+), which is required to read `overrides` from
# pnpm-workspace.yaml consistently with the committed lockfile.
- uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
cache: pnpm
Expand Down Expand Up @@ -56,7 +56,7 @@ jobs:
ref: ${{ github.event.pull_request.head.sha || github.sha }}
persist-credentials: false
- uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
cache: pnpm
Expand Down
9 changes: 9 additions & 0 deletions src/workflowExactHead.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ const workflow = repositoryFile('.github/workflows/ci.yml');

const CHECKOUT_PIN =
'actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1';
const SETUP_NODE_PIN =
'actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0';

describe('exact-head CI workflow contract', () => {
it('uses a fixed runner and checks out the immutable current PR head', () => {
Expand Down Expand Up @@ -43,6 +45,13 @@ describe('exact-head CI workflow contract', () => {
}
});

it('uses the current native-Node-24 setup-node release in every JavaScript job', () => {
expect(workflow.match(new RegExp(SETUP_NODE_PIN, 'g'))).toHaveLength(2);
expect(workflow).not.toContain(
'actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0',
);
});

it('records the evidence boundary and unreleased hardening', () => {
const doctoring = repositoryFile(
'docs/doctoring/exact-head-ci-evidence.md',
Expand Down
Loading