Skip to content

fix(a11y): superseded by evidence-bounded static-empty-state repair #590 - #613

Closed
seonghobae wants to merge 1 commit into
masterfrom
palette-remove-role-status-12201775756120265578
Closed

fix(a11y): superseded by evidence-bounded static-empty-state repair #590#613
seonghobae wants to merge 1 commit into
masterfrom
palette-remove-role-status-12201775756120265578

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Superseded after live comparison

Canonical survivor #590 already carries the valid product/test delta on exact head e5ba27ec8f29ec7be857bb93b80c0a3452e0a458:

  • removes role="status" from the same statically rendered .empty-dir element;
  • updates the exact generated-row regression so the target empty-state markup cannot silently reacquire the role;
  • keeps the visible Korean message, icon, list structure and navigation behavior unchanged;
  • narrows the accessibility claim to the verified semantic boundary: this element is initial static content and does not need live-region semantics.

This branch adds no unique valid production behavior. Its extra .jules/palette.md rule and PR rationale generalize that static role="status" makes screen readers repeat content or disrupt reading flow; that cross-AT behavior was not demonstrated. #590 intentionally removed that unsupported generalization while retaining the WAI-ARIA live-region semantic reason for the target element.

The additional global assertFalse(htmlContent.contains("role=\"status\"")) is also not inherited as a separate product invariant: it forbids any future legitimate status role anywhere in the generated page, while the exact-row regression in #590 binds the requirement to the actual empty-directory element under repair.

Therefore every valid semantic/test delta is already preserved by #590 and the remaining differences are intentionally rejected as overbroad evidence/policy. #590 remains Draft with browser/accessibility-tree resilience evidence and exact-head hosted gates still required; this closure transfers no predecessor GREEN and does not imply merge readiness.

No force-push, destructive rebase, self-approval, or gate weakening is involved.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 930e4aba-9bae-48c0-a773-aff7a4e8ac72

📥 Commits

Reviewing files that changed from the base of the PR and between 55b39b4 and bff17cd.

📒 Files selected for processing (4)
  • .jules/palette.md
  • src/main/kotlin/html4tree/main.kt
  • src/test/kotlin/html4tree/GeneratedIndexReadabilityTest.kt
  • src/test/kotlin/html4tree/MainTest.kt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae changed the title 🎨 Palette: 정적 빈 상태 요소의 role="status" 속성 제거 fix(a11y): superseded by evidence-bounded static-empty-state repair #590 Sep 3, 2026
@seonghobae seonghobae closed this Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant