🎨 Palette: 빈 디렉토리 상태의 접근성 개선 by seonghobae · Pull Request #603 · ContextualWisdomLab/html4tree

seonghobae · 2026-09-02T21:00:51Z

Verified successor: #590 (e5ba27ec8f29ec7be857bb93b80c0a3452e0a458) contains the same product change and the same two structural regressions: static empty-directory text remains visible, role="status" is removed, and list/icon semantics stay intact. #590 also repaired branch contamination and deliberately rejected the unverified cross-screen-reader claim that static role="status" universally causes duplicate/interrupted announcements. The only delta unique to this PR is that over-broad .jules/palette.md rule, which is not valid product/test/contract evidence and should not be inherited. All valid semantic/test delta is therefore fully preserved by #590; close this duplicate rather than maintaining two writers for the same change.

💡 What: 빈 디렉토리 메시지 요소에서 `role="status"` 속성을 제거했습니다. 🎯 Why: 정적으로 렌더링된 요소에 라이브 리전 역할(role="status")을 부여하면, 페이지 로드 시 스크린 리더가 중복해서 안내하거나 읽기 흐름을 방해하는 접근성 안티 패턴이기 때문입니다. 📸 Before/After: 시각적인 변화는 없습니다 (스크린 리더 경험만 개선됨). ♿ Accessibility: 스크린 리더 사용자가 빈 디렉토리 진입 시 더 이상 중복되거나 혼란스러운 안내 메시지를 받지 않게 됩니다.

google-labs-jules · 2026-09-02T21:00:53Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

coderabbitai · 2026-09-02T21:01:07Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 23267029-e690-47c7-85e6-8ea55494230a

📥 Commits

Reviewing files that changed from the base of the PR and between ce55268 and aaffa72.

📒 Files selected for processing (4)

.jules/palette.md
src/main/kotlin/html4tree/main.kt
src/test/kotlin/html4tree/GeneratedIndexReadabilityTest.kt
src/test/kotlin/html4tree/MainTest.kt

💤 Files with no reviewable changes (1)

src/test/kotlin/html4tree/MainTest.kt

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

정적으로 렌더링되는 빈 디렉토리 메시지에서 role="status"를 제거했습니다. 생성되는 시각적 메시지는 유지됩니다. 관련 테스트 기대값과 접근성 학습 항목을 갱신했습니다.

Changes

빈 디렉토리 접근성 마크업 조정

Layer / File(s)	Summary
빈 디렉토리 마크업과 검증 갱신 `.jules/palette.md`, `src/main/kotlin/html4tree/main.kt`, `src/test/kotlin/html4tree/GeneratedIndexReadabilityTest.kt`, `src/test/kotlin/html4tree/MainTest.kt`	빈 디렉토리 메시지에서 `role="status"`를 제거했습니다. 기존 아이콘과 `"이 디렉토리는 비어 있습니다."` 텍스트는 유지됩니다. 관련 테스트 기대값과 접근성 학습 항목을 갱신했습니다.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 29109

Empty-directory messages retain their visible text while no longer being announced as a live status region on initial page load. The targeted markup and test expectation are aligned, with no remaining merge-readiness risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 빈 디렉토리 상태의 접근성 변경을 정확하게 설명합니다. 변경의 핵심인 `role="status"` 제거와 관련되며, 간결하고 이해하기 쉽습니다.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch palette-ux-empty-state-8450165075859532069

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

devin-ai-integration

Devin Review found 1 potential issue.

devin-ai-integration · 2026-09-02T21:01:49Z

readability contract


        if(l.isEmpty()){
-            l.append("""          <li><div class="empty-dir" role="status"><span class="icon" aria-hidden="true">&#128194;</span> <span>이 디렉토리는 비어 있습니다.</span></div></li>""")
+            l.append("""          <li><div class="empty-dir"><span class="icon" aria-hidden="true">&#128194;</span> <span>이 디렉토리는 비어 있습니다.</span></div></li>""")


🔍 Static-status contract remains stale

The readability contract still requires role="status", while the renamed behavior removes it. The test name also preserves the obsolete contract.

Was this helpful? React with 👍 or 👎 to provide feedback.

💡 What: 빈 디렉토리 메시지 요소에서 `role="status"` 속성을 제거했습니다. 🎯 Why: 정적으로 렌더링된 요소에 라이브 리전 역할(role="status")을 부여하면, 페이지 로드 시 스크린 리더가 중복해서 안내하거나 읽기 흐름을 방해하는 접근성 안티 패턴이기 때문입니다. 📸 Before/After: 시각적인 변화는 없습니다 (스크린 리더 경험만 개선됨). ♿ Accessibility: 스크린 리더 사용자가 빈 디렉토리 진입 시 더 이상 중복되거나 혼란스러운 안내 메시지를 받지 않게 됩니다.

devin-ai-integration Bot reviewed Sep 2, 2026

View reviewed changes

seonghobae added 2 commits September 3, 2026 10:01

seonghobae closed this Sep 3, 2026

Navigation Menu

Uh oh!

🎨 Palette: 빈 디렉토리 상태의 접근성 개선 - #603

🎨 Palette: 빈 디렉토리 상태의 접근성 개선#603
seonghobae wants to merge 3 commits into
masterfrom
palette-ux-empty-state-8450165075859532069

seonghobae commented Sep 2, 2026 •

edited

Loading

Uh oh!

google-labs-jules Bot commented Sep 2, 2026

Uh oh!

coderabbitai Bot commented Sep 2, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

devin-ai-integration Bot Sep 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

seonghobae commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-labs-jules Bot commented Sep 2, 2026

Uh oh!

coderabbitai Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

seonghobae commented Sep 2, 2026 •

edited

Loading

coderabbitai Bot commented Sep 2, 2026 •

edited

Loading