Skip to content

🎨 Palette: [UX improvement] BiDi ν…μŠ€νŠΈ 지원을 μœ„ν•œ dir="auto" μΆ”κ°€ - #583

Open
seonghobae wants to merge 5 commits into
masterfrom
palette-bidi-text-support-12367038015721521754
Open

🎨 Palette: [UX improvement] BiDi ν…μŠ€νŠΈ 지원을 μœ„ν•œ dir="auto" μΆ”κ°€#583
seonghobae wants to merge 5 commits into
masterfrom
palette-bidi-text-support-12367038015721521754

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

πŸ’‘ What (무엇을)

html4treeκ°€ μƒμ„±ν•˜λŠ” HTML 디렉토리 λͺ©λ‘μ—μ„œ ν…μŠ€νŠΈλ₯Ό ν¬ν•¨ν•˜λŠ” <h1> 및 <span> μš”μ†Œμ— dir="auto" 속성을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why (μ™œ)

μ•„λžμ–΄λ‚˜ νžˆλΈŒλ¦¬μ–΄μ™€ 같이 였λ₯Έμͺ½μ—μ„œ μ™Όμͺ½(RTL)으둜 μ½λŠ” λ¬Έμžκ°€ λ””λ ‰ν† λ¦¬λ‚˜ 파일 이름에 ν¬ν•¨λ˜μ–΄ μžˆμ„ λ•Œ, μ™Όμͺ½μ—μ„œ 였λ₯Έμͺ½(LTR) λ ˆμ΄μ•„μ›ƒ λ‚΄μ—μ„œλ„ λ¬Έμžκ°€ μ˜¬λ°”λ₯΄κ²Œ λ Œλ”λ§λ˜λ„λ‘ μ–‘λ°©ν–₯(BiDi) ν…μŠ€νŠΈλ₯Ό 적절히 μ§€μ›ν•˜κΈ° μœ„ν•¨μž…λ‹ˆλ‹€. 이λ₯Ό 톡해 λ‹€κ΅­μ–΄ 파일 μ‹œμŠ€ν…œ ν™˜κ²½μ—μ„œμ˜ μ‚¬μš©μ„±μ„ κ°œμ„ ν•©λ‹ˆλ‹€.

πŸ“Έ Before/After (이전/이후)

Before:

<h1>폴더이름</h1>
...
<span aria-hidden="true">..</span>
...
<span>νŒŒμΌμ΄λ¦„.txt</span>
...
<span>이 λ””λ ‰ν† λ¦¬λŠ” λΉ„μ–΄ μžˆμŠ΅λ‹ˆλ‹€.</span>

After:

<h1 dir="auto">폴더이름</h1>
...
<span aria-hidden="true" dir="auto">..</span>
...
<span dir="auto">νŒŒμΌμ΄λ¦„.txt</span>
...
<span dir="auto">이 λ””λ ‰ν† λ¦¬λŠ” λΉ„μ–΄ μžˆμŠ΅λ‹ˆλ‹€.</span>

β™Ώ Accessibility (μ ‘κ·Όμ„±)

λ‹€μ–‘ν•œ 언어와 μ–‘λ°©ν–₯ ν…μŠ€νŠΈκ°€ μ„žμ—¬ μžˆλŠ” κ²½μš°μ—λ„ 파일λͺ…이 λΈŒλΌμš°μ €μ— μ˜ν•΄ μ˜¬λ°”λ₯΄κ²Œ ν‘œμ‹œλ˜λ„λ‘ 보μž₯ν•˜μ—¬, μ‹œκ°μ  ν˜Όλž€μ„ λ°©μ§€ν•˜κ³  μ •ν™•ν•œ ν…μŠ€νŠΈ λ Œλ”λ§μ„ μ§€μ›ν•©λ‹ˆλ‹€.


PR created automatically by Jules for task 12367038015721521754 started by @seonghobae


Devin Review

Summary by CodeRabbit

  • κ°œμ„  사항

    • 였λ₯Έμͺ½μ—μ„œ μ™Όμͺ½μœΌλ‘œ μž‘μ„±λ˜λŠ” λ¬Έμžκ°€ ν¬ν•¨λœ 디렉터리 및 파일 이름을 μ˜¬λ°”λ₯Έ λ°©ν–₯으둜 ν‘œμ‹œν•©λ‹ˆλ‹€.
    • 디렉터리 제λͺ©, μƒμœ„ 디렉터리 링크, ν•­λͺ© 이름 및 빈 디렉터리 μ•ˆλ‚΄μ—λ„ ν…μŠ€νŠΈ λ°©ν–₯이 μžλ™ μ μš©λ©λ‹ˆλ‹€.
  • ν…ŒμŠ€νŠΈ

    • λ‹€μ–‘ν•œ 디렉터리 ν‘œμ‹œ μƒν™©μ—μ„œ ν…μŠ€νŠΈ λ°©ν–₯ 속성이 μ˜¬λ°”λ₯΄κ²Œ μ μš©λ˜λŠ”μ§€ κ²€μ¦ν•˜λ„λ‘ ν…ŒμŠ€νŠΈλ₯Ό μ—…λ°μ΄νŠΈν–ˆμŠ΅λ‹ˆλ‹€.
  • λ¬Έμ„œ

    • μ–‘λ°©ν–₯ ν…μŠ€νŠΈ 지원을 μœ„ν•œ ꢌμž₯ 사항을 ν•™μŠ΅ μžλ£Œμ— μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

Updated main.kt to include `dir="auto"` on `<h1>` and `<span>` elements holding user-provided directory or file names. This ensures proper bidirectional text rendering (e.g., Arabic, Hebrew). Updated the test suite assertions in MainTest.kt and GeneratedIndexReadabilityTest.kt to match the new markup. Verified 100% test coverage. Added journal entry in Korean to .jules/palette.md.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: fb84858b-7baf-49dd-a13d-f96a78c23dbe

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between de82f99 and cbeb605.

πŸ“’ Files selected for processing (4)
  • .jules/palette.md
  • src/main/kotlin/html4tree/main.kt
  • src/test/kotlin/html4tree/GeneratedIndexReadabilityTest.kt
  • src/test/kotlin/html4tree/MainTest.kt

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


πŸ“ Walkthrough

Walkthrough

μƒμ„±λœ 디렉토리 λͺ©λ‘μ˜ 제λͺ©, 링크, ν•­λͺ© 이름, 빈 디렉토리 λ©”μ‹œμ§€μ— dir="auto"λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. κ΄€λ ¨ ν…ŒμŠ€νŠΈμ™€ BiDi 지원 μ•ˆλ‚΄λ₯Ό μ—…λ°μ΄νŠΈν–ˆμŠ΅λ‹ˆλ‹€.

Changes

BiDi HTML 지원

Layer / File(s) Summary
HTML 좜λ ₯ 및 νšŒκ·€ 검증
src/main/kotlin/html4tree/main.kt, src/test/kotlin/html4tree/*Test.kt, .jules/palette.md
HTML ν…μŠ€νŠΈ μš”μ†Œμ— dir="auto"λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. μƒμ„±λœ λ§ˆν¬μ—…μ„ κ²€μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈμ™€ BiDi 지원 μ•ˆλ‚΄λ₯Ό κ°±μ‹ ν–ˆμŠ΅λ‹ˆλ‹€.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: βšͺ Minimal Β· up to cbeb6

This change improves BiDi text rendering in generated directory listings and is merge-ready after normal checks, with no actionable merge-blocking risk remaining.

Possibly related PRs

  • ContextualWisdomLab/html4tree#447: λ™μΌν•œ HTML 생성 μ½”λ“œμ™€ ν…ŒμŠ€νŠΈμ—μ„œ BiDi ν…μŠ€νŠΈμš© dir="auto"λ₯Ό μΆ”κ°€ν•©λ‹ˆλ‹€.

Suggested reviewers: copilot

πŸš₯ Pre-merge checks | βœ… 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
βœ… Passed checks (4 passed)
Check name Status Explanation
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed PR 제λͺ©μ€ μƒμ„±λœ HTML μš”μ†Œμ— dir="auto"λ₯Ό μΆ”κ°€ν•˜μ—¬ BiDi ν…μŠ€νŠΈλ₯Ό μ§€μ›ν•˜λŠ” μ£Όμš” λ³€κ²½ 사항을 μ •ν™•ν•˜κ³  ꡬ체적으둜 μ„€λͺ…ν•©λ‹ˆλ‹€.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches πŸ’‘ 1
πŸ“ Generate docstrings πŸ’‘
  • Create stacked PR
  • Commit on current branch
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-bidi-text-support-12367038015721521754

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Updated main.kt to include `dir="auto"` on `<h1>` and `<span>` elements holding user-provided directory or file names. This ensures proper bidirectional text rendering (e.g., Arabic, Hebrew). Updated the test suite assertions in MainTest.kt and GeneratedIndexReadabilityTest.kt to match the new markup. Verified 100% test coverage. Added journal entry in Korean to .jules/palette.md.
Updated main.kt to include `dir="auto"` on `<h1>` and `<span>` elements holding user-provided directory or file names. This ensures proper bidirectional text rendering (e.g., Arabic, Hebrew). Updated the test suite assertions in MainTest.kt and GeneratedIndexReadabilityTest.kt to match the new markup. Verified 100% test coverage. Added journal entry in Korean to .jules/palette.md.
Updated main.kt to include `dir="auto"` on `<h1>` and `<span>` elements holding user-provided directory or file names. This ensures proper bidirectional text rendering (e.g., Arabic, Hebrew). Updated the test suite assertions in MainTest.kt and GeneratedIndexReadabilityTest.kt to match the new markup. Verified 100% test coverage. Added journal entry in Korean to .jules/palette.md.
Updated main.kt to include `dir="auto"` on `<h1>` and `<span>` elements holding user-provided directory or file names. This ensures proper bidirectional text rendering (e.g., Arabic, Hebrew). Updated the test suite assertions in MainTest.kt and GeneratedIndexReadabilityTest.kt to match the new markup. Verified 100% test coverage. Added journal entry in Korean to .jules/palette.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant