π¨ Palette: [UX improvement] BiDi ν μ€νΈ μ§μμ μν dir="auto" μΆκ° - #583
π¨ Palette: [UX improvement] BiDi ν
μ€νΈ μ§μμ μν dir="auto" μΆκ°#583seonghobae wants to merge 5 commits into
Conversation
Updated main.kt to include `dir="auto"` on `<h1>` and `<span>` elements holding user-provided directory or file names. This ensures proper bidirectional text rendering (e.g., Arabic, Hebrew). Updated the test suite assertions in MainTest.kt and GeneratedIndexReadabilityTest.kt to match the new markup. Verified 100% test coverage. Added journal entry in Korean to .jules/palette.md.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: π Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. π WalkthroughWalkthroughμμ±λ λλ ν 리 λͺ©λ‘μ μ λͺ©, λ§ν¬, νλͺ© μ΄λ¦, λΉ λλ ν 리 λ©μμ§μ ChangesBiDi HTML μ§μ
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: βͺ Minimal Β· up to This change improves BiDi text rendering in generated directory listings and is merge-ready after normal checks, with no actionable merge-blocking risk remaining. Possibly related PRs
Suggested reviewers: π₯ Pre-merge checks | β 4 | β 1β Failed checks (1 warning)
β Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1 unsupported.)
β¨ Finishing Touches π‘ 1π Generate docstrings π‘
π§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Updated main.kt to include `dir="auto"` on `<h1>` and `<span>` elements holding user-provided directory or file names. This ensures proper bidirectional text rendering (e.g., Arabic, Hebrew). Updated the test suite assertions in MainTest.kt and GeneratedIndexReadabilityTest.kt to match the new markup. Verified 100% test coverage. Added journal entry in Korean to .jules/palette.md.
Updated main.kt to include `dir="auto"` on `<h1>` and `<span>` elements holding user-provided directory or file names. This ensures proper bidirectional text rendering (e.g., Arabic, Hebrew). Updated the test suite assertions in MainTest.kt and GeneratedIndexReadabilityTest.kt to match the new markup. Verified 100% test coverage. Added journal entry in Korean to .jules/palette.md.
Updated main.kt to include `dir="auto"` on `<h1>` and `<span>` elements holding user-provided directory or file names. This ensures proper bidirectional text rendering (e.g., Arabic, Hebrew). Updated the test suite assertions in MainTest.kt and GeneratedIndexReadabilityTest.kt to match the new markup. Verified 100% test coverage. Added journal entry in Korean to .jules/palette.md.
Updated main.kt to include `dir="auto"` on `<h1>` and `<span>` elements holding user-provided directory or file names. This ensures proper bidirectional text rendering (e.g., Arabic, Hebrew). Updated the test suite assertions in MainTest.kt and GeneratedIndexReadabilityTest.kt to match the new markup. Verified 100% test coverage. Added journal entry in Korean to .jules/palette.md.
π‘ What (무μμ)
html4treeκ° μμ±νλ HTML λλ ν 리 λͺ©λ‘μμ ν μ€νΈλ₯Ό ν¬ν¨νλ
<h1>λ°<span>μμμdir="auto"μμ±μ μΆκ°νμ΅λλ€.π― Why (μ)
μλμ΄λ νλΈλ¦¬μ΄μ κ°μ΄ μ€λ₯Έμͺ½μμ μΌμͺ½(RTL)μΌλ‘ μ½λ λ¬Έμκ° λλ ν 리λ νμΌ μ΄λ¦μ ν¬ν¨λμ΄ μμ λ, μΌμͺ½μμ μ€λ₯Έμͺ½(LTR) λ μ΄μμ λ΄μμλ λ¬Έμκ° μ¬λ°λ₯΄κ² λ λλ§λλλ‘ μλ°©ν₯(BiDi) ν μ€νΈλ₯Ό μ μ ν μ§μνκΈ° μν¨μ λλ€. μ΄λ₯Ό ν΅ν΄ λ€κ΅μ΄ νμΌ μμ€ν νκ²½μμμ μ¬μ©μ±μ κ°μ ν©λλ€.
πΈ Before/After (μ΄μ /μ΄ν)
Before:
After:
βΏ Accessibility (μ κ·Όμ±)
λ€μν μΈμ΄μ μλ°©ν₯ ν μ€νΈκ° μμ¬ μλ κ²½μ°μλ νμΌλͺ μ΄ λΈλΌμ°μ μ μν΄ μ¬λ°λ₯΄κ² νμλλλ‘ λ³΄μ₯νμ¬, μκ°μ νΌλμ λ°©μ§νκ³ μ νν ν μ€νΈ λ λλ§μ μ§μν©λλ€.
PR created automatically by Jules for task 12367038015721521754 started by @seonghobae
Summary by CodeRabbit
κ°μ μ¬ν
ν μ€νΈ
λ¬Έμ