security(html): neutralize bidi controls at the display boundary - #580
Draft
seonghobae wants to merge 3 commits into
Draft
security(html): neutralize bidi controls at the display boundary#580seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer-visible security boundary
A filename containing Unicode bidirectional formatting controls must not visually hide its real extension in the generated directory listing. The real filesystem name must still be used for the link target.
This clean current-
masterreplacement avoids #454's globalescapeHtml()stripping, which mixes HTML escaping with filename trust policy and can delete renderer-owned bidi isolation marks. It also avoids importing the unrelated size/mtime and other product changes from closed #463.Test-first state
RED head
c7d89cc8e123a03eebc29cdb48f7cb14701327deadds generated-page regressions before production changes. They require:href;The RED head is intentionally not merge-ready because the production functions and rendering boundary do not exist yet.
Scope
Base:
master@de82f99f66fc9e190398f9bb1c8c6bd69bd88a30.No Storybook or Figma integration exists in this static Kotlin-generated HTML product, and this slice changes the security rendering contract rather than layout or visual design. Existing CSS and translatable hidden type labels remain owned by the current base.
Supersedes #454 after this replacement proves current-head CI/security/review evidence.
Merge contract
Keep Draft until the unchanged exact head has repository tests/coverage/security gates and all live central required workflows terminal-success, zero actionable current-head review findings, and a qualifying independent non-author approval. Do not bypass protection or treat skipped/predecessor evidence as passing.