feat(multilevel): estimate crossed multiple-membership u_h - #985
feat(multilevel): estimate crossed multiple-membership u_h#985seonghobae wants to merge 9 commits into
Conversation
Add a Rust-owned MAP/Newton kernel for Fox & Glas mixed-effects IRT person effects with Browne MMMC crossed and weighted membership. The O(P*I) score reduction is CPU-multithreaded and optionally GPU-backed. Python only marshals a sealed design. Recovery is RMSE vs true u_h. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Warning Review limit reached
Next review available in: 18 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (18)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The crossed u_h binding now uses PyValueError::new_err, and the APA 7th doctoring test accepts the wrapped Browne MMMC title. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head34697b6df58c1424654bc890571a3dfbe806fd97. -
Head SHA:
34697b6df58c1424654bc890571a3dfbe806fd97 -
Workflow run: 32124700402
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (7 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (7 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (8 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (8 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test (3 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (3 files)"]
R3 --> V3["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (7 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (7 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (8 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (8 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test (3 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (3 files)"]
R3 --> V3["targeted test run"]
|
|
@opencode-agent Please re-review unchanged exact head |
|
@opencode-agent Please re-review unchanged exact head |
Scope
Buyer-visible psychometrics gap on current protected main: estimate crossed / weighted multiple-membership person effects
u_h. This is not another OLS/AR slice and is not stacked on #976, #982, or #939.Paper basis
Fox and Glas (2001) place a Gaussian level-2 prior on multilevel IRT group effects. Browne, Goldstein, and Rasbash (2001) write the same additive term with membership weights that sum to one inside each classification, including multiple membership and crossed (multiple-classification) designs.
Implemented linear predictor:
This kernel is the matching MAP / Newton point estimator of flattened
u_h, not Fox & Glas Gibbs and not MMMC MCMC. Optionalperson_offsetsaccept an already-estimated longitudinal location. OLS/AR coefficients are not estimated here because #976 is not on main.What landed
mlsirm-corewith CPU multithreading and an optional wgpu person-score kernel (f64 CPU fallback).estimate_crossed_person_effects,CrossedPersonEffectResult.Exclusions
NVIDIA_NIM_API_KEYunused).Evidence on this head (
03ebb0eb86bc4325bc5d5240b885069cea103ff7)cargo test --locked --manifest-path crates/mlsirm-core/Cargo.toml --lib multilevel::estimator: 5 passed, including the Rust RMSE gate.python -c "resolve_backend(auto) == rust": rust primary OK.pytestrecovery + doctoring + existing multilevel/contracts/changelog/docs: 26 passed, includingtest_crossed_multiple_membership_uh_recovers_true_effects.zero_rmse > 0.70vs recovered RMSE< 0.25).