🎨 Palette: [UX improvement] Improve focus styles for main content - #978
🎨 Palette: [UX improvement] Improve focus styles for main content#978seonghobae wants to merge 3 commits into
Conversation
Modifies the `:focus` rule on `<main>` to `:not(:focus-visible)` in `report.py` to ensure keyboard focus rings appear while suppressing mouse click rings.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe report CSS now suppresses pointer-triggered outlines on ChangesAccessibility focus handling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized accessibility improvement restores visible focus styling for keyboard users while preserving the existing experience for mouse and touch users; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@opencode-agent Please review exact head |
|
@coderabbitai review |
✅ Action performedReview finished.
|
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headcb398e3fc44033a30e7177f7d561da14d2742dc6. -
Head SHA:
cb398e3fc44033a30e7177f7d561da14d2742dc6 -
Workflow run: 32124679471
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test_report_numeric_motion_css.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_report_numeric_motion_css.py"]
R2 --> V2["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test_report_numeric_motion_css.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_report_numeric_motion_css.py"]
R2 --> V2["targeted test run"]
|
|
@opencode-agent Please re-review unchanged exact head |
|
@opencode-agent Please re-review unchanged exact head |
|
Superseded by #1002. The successor preserves this exact accessibility behavior and focused regression, removes only the bot-local |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
💡 What: Modified the
main:focus { outline: none; }CSS rule inpython/fast_mlsirm/report.pytomain:focus:not(:focus-visible) { outline: none; }.🎯 Why: When users use a "skip to main content" link (which targets
<main tabindex="-1">), the previousoutline: none;rule completely removed the focus ring, leaving keyboard users without a visual indicator of where their focus landed.♿ Accessibility: This change perfectly preserves the visual UX for mouse/touch users (who won't see a massive focus ring if they happen to click the main area) while correctly restoring the browser's focus indicator for keyboard users navigating via skip links. This brings the generic report CSS into alignment with the explicit accessibility rules already implemented in the essay scoring sub-reports.
PR created automatically by Jules for task 1487165751651455508 started by @seonghobae
Summary by CodeRabbit
Accessibility
Bug Fixes
Tests