Skip to content

🎨 Palette: [UX improvement] Remove default focus outline on summary click - #968

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette-summary-focus-outline-1218521190196489870
Closed

🎨 Palette: [UX improvement] Remove default focus outline on summary click#968
seonghobae wants to merge 1 commit into
mainfrom
palette-summary-focus-outline-1218521190196489870

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

💡 What: HTML 리포트의 <summary> 요소에서 클릭 시 발생하는 기본 포커스 윤곽선을 :focus 상태일 때 숨깁니다.
🎯 Why: 마우스 사용 시 불필요하고 투박한 기본 아웃라인이 나타나는 현상을 방지하여 UI의 완성도와 사용성을 높입니다. 키보드 사용 시에는 :focus-visible을 통해 접근성을 유지합니다.
📸 Before/After: (시각적 변경 사항 없음, 클릭 시에만 적용)
♿ Accessibility: 마우스 사용자 경험 향상을 위해 아웃라인을 숨기되, 키보드 네비게이션을 위한 :focus-visible 규칙은 그대로 작동하도록 보장합니다.


PR created automatically by Jules for task 1218521190196489870 started by @seonghobae

마우스 사용자가 HTML 리포트 내 `<summary>` 요소(`.exact-values` 및 `.export-block` 컨테이너 내부)를 클릭할 때 나타나는 브라우저 기본 포커스 윤곽선(`outline`)을 제거하여 시각적으로 더 깔끔한 경험을 제공합니다. 키보드 네비게이션 시 필요한 윤곽선은 `:focus-visible` 규칙을 통해 여전히 유지됩니다.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 21e04cca-0830-4ed5-bbf5-00eaf29a991b

📥 Commits

Reviewing files that changed from the base of the PR and between 11e0fab and ad3f164.

📒 Files selected for processing (2)
  • python/fast_mlsirm/report.py
  • tests/test_report_focus_contrast.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Closing this lane rather than merging it. The current patch adds bare summary:focus { outline: none; } rules, which can remove the native keyboard-focus fallback in user agents where :focus-visible is unsupported or unusable. PR #928 already owns the same report-focus surface and uses the safer bounded selector :focus:not(:focus-visible) while retaining explicit :focus-visible indicators. Keeping #968 open would therefore create a competing, less-safe implementation of the same mutable CSS/test scope. No product behavior from #968 is needed beyond what #928 already covers.

@seonghobae seonghobae closed this Aug 17, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing this lane rather than merging it. The current patch adds bare summary:focus { outline: none; } rules, which can remove the native keyboard-focus fallback in user agents where :focus-visible is unsupported or unusable. PR #928 already owns the same report-focus surface and uses the safer bounded selector :focus:not(:focus-visible) while retaining explicit :focus-visible indicators. Keeping #968 open would therefore create a competing, less-safe implementation of the same mutable CSS/test scope. No product behavior from #968 is needed beyond what #928 already covers.

Understood. Acknowledging that this work is now obsolete as it is covered by PR #928. Stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant