Skip to content

🎨 Palette: <main> 요소 클릭 시 불필요한 포커스 윤곽선 제거 - #917

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette-fix-main-focus-outline-10147155119841506160
Closed

🎨 Palette: <main> 요소 클릭 시 불필요한 포커스 윤곽선 제거#917
seonghobae wants to merge 1 commit into
mainfrom
palette-fix-main-focus-outline-10147155119841506160

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

💡 What: HTML 보고서 생성기(report_html.py)에 main:focus { outline: none; } CSS 규칙을 추가하여 마우스 클릭 시 발생하는 불필요한 포커스 윤곽선을 제거했습니다.
🎯 Why: <main> 요소가 '본문으로 건너뛰기' 링크를 위해 tabindex="-1" 속성을 가지고 있을 때, 사용자가 빈 공간을 마우스로 클릭하면 브라우저 기본 포커스 윤곽선이 나타나 시각적으로 매우 산만해지는 UX 문제를 해결하기 위함입니다.
📸 Before/After: 본문 영역 마우스 클릭 시 화면을 덮는 파란색 윤곽선이 사라졌습니다.
♿ Accessibility: 키보드 탐색 접근성을 보장하기 위해 기존의 main:focus-visible 규칙은 그대로 유지되어, 탭 키로 접근할 때만 포커스 인디케이터가 명확하게 표시되도록 하였습니다.


PR created automatically by Jules for task 10147155119841506160 started by @seonghobae

HTML 보고서 생성기에서 <main> 요소(`tabindex="-1"`)를 마우스로 클릭할 때 발생하는 불필요하고 거대한 포커스 윤곽선을 제거하여 시각적 경험을 개선합니다. 키보드 사용자를 위한 `:focus-visible` 윤곽선은 명시적으로 유지됩니다.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9a0305f1-e7cb-4e69-8c79-7abeb721741b

📥 Commits

Reviewing files that changed from the base of the PR and between fb67ced and 7dfa174.

📒 Files selected for processing (3)
  • .Jules/palette.md
  • python/fast_mlsirm/scoring/essay/report_html.py
  • tests/test_scoring_essay_report_html.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Closing as a proven duplicate of #822. Fresh comparison against protected main fb67ced09d8ee00542c05d56374537a9a7239751 shows the production report_html.py patch is byte-for-byte the same (main:focus { outline: none; }) and the shared tests/test_scoring_essay_report_html.py assertion change is also identical. #822 already carries the dedicated pointer-focus regression plus the canonical changelog/evidence lineage, so maintaining this second same-scope branch would create unnecessary collision risk. No finding from this PR is discarded; its intended behavior is preserved by #822.

@seonghobae seonghobae closed this Aug 15, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as a proven duplicate of #822. Fresh comparison against protected main fb67ced09d8ee00542c05d56374537a9a7239751 shows the production report_html.py patch is byte-for-byte the same (main:focus { outline: none; }) and the shared tests/test_scoring_essay_report_html.py assertion change is also identical. #822 already carries the dedicated pointer-focus regression plus the canonical changelog/evidence lineage, so maintaining this second same-scope branch would create unnecessary collision risk. No finding from this PR is discarded; its intended behavior is preserved by #822.

Understood. Acknowledging that this work is a duplicate of #822 and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant