Skip to content

fix(rubric): harden G-theory pilot control callbacks - #882

Merged
seonghobae merged 8 commits into
mainfrom
fix/rubric-gtheory-pilot-control-callbacks-881
Aug 16, 2026
Merged

fix(rubric): harden G-theory pilot control callbacks#882
seonghobae merged 8 commits into
mainfrom
fix/rubric-gtheory-pilot-control-callbacks-881

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Scope

Fix #881 at the generated-item G-theory pilot handoff validation boundary without changing G-theory arithmetic or Rust numerical ownership.

Test-first lineage

  • RED public-handoff regressions: 548c83ce22465b4068346811b074825253c98a6c.
  • Initial exact-type implementation: eba56e35d0ef0a8aa03e41f8a2d2a91f4a3c1433.
  • Changelog / doctoring evidence: 3d213cd3083b6082a45212f4841b4dfc0cf51877 / 900e21c537d5e79127ab22c17fc1d851df895f2d.
  • Genuine NumPy-subclass test construction correction: 77cea62c9c6692b3a9aa335dabd67d7f85bd2371.
  • RED metaclass-dispatch regression: 0d79240fda99c5aa0c29f6b84c9f200d8d66a26a.
  • GREEN identity-only scalar-type admission: a734e01a872c7aaabf19a74b1fc212d88d4d084f.
  • Exact current head 9f527f316487fb0338f2eb6570d8f42924d42b14 repairs the release fragment to the repository's required level-one-title / classified-section grammar after the same format defect was reproduced on the parallel testlet-pilot lane.

The implementation uses identity-only comparisons before trusted NumPy conversion, so caller-controlled metaclass hashing/equality cannot participate in control admission.

Boundaries

  • preserve the 64-row materialization limit and 1..=1_000_000 D-study-size domain;
  • preserve finite mastery-cut semantics;
  • preserve genuine NumPy integer/floating scalar compatibility;
  • reject caller-defined numeric/protocol subclasses before conversion, representation, hashing, or equality callbacks;
  • Python remains validation/marshalling only;
  • no formula, estimator, provider, dependency, database, workflow, release-version, or gate change.

Exact current state

  • Protected base: fb67ced09d8ee00542c05d56374537a9a7239751.
  • Exact source head: 9f527f316487fb0338f2eb6570d8f42924d42b14.
  • GitHub reports the PR mergeable and Ready for review.
  • Exact-head CI completed successfully, including Python 3.12/3.14, Rust, package, GPU smoke, and fuzz.
  • Exact-head Security Scan and SAST Semgrep completed successfully; the 33 current check-runs contain no failure or in-progress result.
  • No formal submitted review or unresolved inline review thread is present.
  • Integration still requires the protected-main qualifying independent non-author approval and all live required contexts at merge time. No gate is weakened or bypassed.

Any future source-head or protected-base movement invalidates this evidence and requires a fresh sweep.

Fixes #881.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a21253a5-bac7-4cf7-8980-0e43f0403af6

📥 Commits

Reviewing files that changed from the base of the PR and between fb67ced and 9f527f3.

📒 Files selected for processing (4)
  • docs/changelog.d/881-rubric-gtheory-pilot-control-callbacks.md
  • docs/doctoring/rubric_gtheory_pilot_control_callbacks.md
  • python/fast_mlsirm/rubric/gtheory_pilot.py
  • tests/test_rubric_gtheory_pilot_control_callbacks.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 15, 2026 07:18
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 07:19
@seonghobae
seonghobae merged commit 724fee3 into main Aug 16, 2026
35 checks passed
@seonghobae
seonghobae deleted the fix/rubric-gtheory-pilot-control-callbacks-881 branch August 16, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harden rubric G-theory pilot controls before caller callbacks

1 participant