Skip to content

feat(item-bank): enforce immutable lifecycle transitions - #829

Closed
seonghobae wants to merge 4 commits into
mainfrom
feat/item-bank-transition-contract-609
Closed

feat(item-bank): enforce immutable lifecycle transitions#829
seonghobae wants to merge 4 commits into
mainfrom
feat/item-bank-transition-contract-609

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Closed unmerged — duplicate lifecycle authority

Fresh protected-main inspection after this Draft was opened found the canonical lifecycle implementation that this branch would duplicate:

Therefore adding a second transition state machine to python/fast_mlsirm/scoring/item_bank.py would violate #609's requirement to reuse existing rubric/lifecycle contracts rather than create a parallel schema/authority. The commits on this branch are intentionally not merged.

The branch's RED/GREEN experiments are retained only as historical diagnostic evidence. No protected-main behavior depends on them, and no predecessor-head CI/review evidence should be reused.

Next #609 work must advance one of the still-open acceptance stages against the canonical fast_mlsirm.rubric lifecycle boundary rather than duplicate lifecycle transition ownership.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f04f8a0-9e3d-4a69-8023-f18462bba884

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant