feat(item-bank): enforce immutable lifecycle transitions - #829
Closed
seonghobae wants to merge 4 commits into
Closed
feat(item-bank): enforce immutable lifecycle transitions#829seonghobae wants to merge 4 commits into
seonghobae wants to merge 4 commits into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed unmerged — duplicate lifecycle authority
Fresh protected-main inspection after this Draft was opened found the canonical lifecycle implementation that this branch would duplicate:
python/fast_mlsirm/rubric/item_bank.pyalready owns the factory-sealedItemBankLifecycleRecord, exact predecessor replay, explicit post-pilot state graph, cumulative evidence, approved-use preservation, and fail-closedtransition_item_bank_record(...)boundary;docs/doctoring/governed_item_bank_lifecycle.mdalready documents that transition authority;Therefore adding a second transition state machine to
python/fast_mlsirm/scoring/item_bank.pywould violate #609's requirement to reuse existing rubric/lifecycle contracts rather than create a parallel schema/authority. The commits on this branch are intentionally not merged.The branch's RED/GREEN experiments are retained only as historical diagnostic evidence. No protected-main behavior depends on them, and no predecessor-head CI/review evidence should be reused.
Next #609 work must advance one of the still-open acceptance stages against the canonical
fast_mlsirm.rubriclifecycle boundary rather than duplicate lifecycle transition ownership.