Skip to content

fix(multilevel): reject hostile numeric conversion hooks - #790

Merged
seonghobae merged 1 commit into
fix/fitstats-m2-infit-docs-greenfrom
fix/multilevel-hostile-numeric-green
Aug 12, 2026
Merged

fix(multilevel): reject hostile numeric conversion hooks#790
seonghobae merged 1 commit into
fix/fitstats-m2-infit-docs-greenfrom
fix/multilevel-hostile-numeric-green

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Fail-closed multilevel membership-weight and AR(1) scalar validation using exact built-in numeric types only.

Supersedes draft #785. Local multilevel suite 58 passed.

Product gates

Merge when python + rust + package + fuzz are green.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a8dc281a-901d-40c3-9310-0a007eb9fec7

📥 Commits

Reviewing files that changed from the base of the PR and between c91ae21 and aaec777.

📒 Files selected for processing (14)
  • CHANGELOG.md
  • docs/changelog.d/776-fitstats-infit-m2-failclosed.md
  • docs/changelog.d/777-docs-coverage-vocabulary-sync.md
  • docs/changelog.d/785-multilevel-hostile-numeric-callbacks.md
  • docs/documentation_coverage.md
  • python/fast_mlsirm/fitstats.py
  • python/fast_mlsirm/multilevel/_validation.py
  • tests/test_architecture_documentation_contract.py
  • tests/test_cov_c_fitstats.py
  • tests/test_documentation_coverage_fitness.py
  • tests/test_fitstats_infit_outfit_allocations.py
  • tests/test_fitstats_infit_outfit_rust_ownership_failclosed.py
  • tests/test_fitstats_m2_rust_ownership.py
  • tests/test_multilevel_hostile_numeric_callbacks.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
fix(multilevel): reject hostile numeric conversion hooks
aaec777 
Fail closed on float subclasses for membership weights and AR(1)
coefficients so hostile __float__ callbacks cannot leak into contract
errors. Stacked on fitstats/docs fail-closed base for product CI.
@seonghobae
seonghobae force-pushed the fix/multilevel-hostile-numeric-green branch from fa2c8ff to aaec777 Compare August 12, 2026 06:46
@seonghobae

seonghobae commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto fitstats/docs fail-closed base (incl. S-X2/person-fit cov retargets) so product CI is not blocked by main docs/fallback debt.

@seonghobae
seonghobae changed the base branch from main to fix/fitstats-m2-infit-docs-green August 12, 2026 07:14
@seonghobae
seonghobae merged commit 1bd10f6 into fix/fitstats-m2-infit-docs-green Aug 12, 2026
33 checks passed
@seonghobae
seonghobae deleted the fix/multilevel-hostile-numeric-green branch August 12, 2026 07:16
seonghobae added a commit that referenced this pull request Aug 12, 2026
@seonghobae
fix(fitstats): fail closed for M2 and infit/outfit ownership (#788)
6394888 
* fix(fitstats): fail closed for M2 and infit/outfit ownership

Require compiled m2_stat and infit_outfit_stat for ordinary public calls,
retarget NumPy-fallback coverage, and sync documentation maturity vocabulary
plus shipped capability rows for parallel bounds and dark-mode accents.

* docs: scope protected rotation status evidence

* test(fitstats): retarget S-X2/person-fit cov fallbacks fail-closed

#771 already fails closed for public S-X2 and person-fit; keep the cov-C
NumPy-fallback suite aligned so product CI does not re-execute removed
reference bodies.

* fix(multilevel): reject hostile numeric conversion hooks (#790)

Fail closed on float subclasses for membership weights and AR(1)
coefficients so hostile __float__ callbacks cannot leak into contract
errors. Stacked on fitstats/docs fail-closed base for product CI.
@seonghobae seonghobae mentioned this pull request Aug 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@seonghobae