fix(rubric): redact hostile iterable failures - #783
Closed
seonghobae wants to merge 3 commits into
Closed
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Superseded by GREEN. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reliability/security defect
Public rubric constructors accept caller-provided iterables. The shared bounded-materialization helper on protected
mainallowed runtime exceptions raised by iterator construction or advancement to cross a package-owned validation boundary with caller-controlled type/message text.Test-first RED -> narrow GREEN
The fail-first slice established the public
RubricSpecificationboundary with hostile iterators. The current exact head isc6d73b685c22affaa5f4d85577ab427570d45267over protectedmainc91ae210bc8e0340a5b0587cf5289b82a2e8ab92.The production fix is confined to the shared bounded-materialization helper:
ValueError;MemoryErrorremains an explicit resource-exhaustion signal at both boundaries;Permanent public-boundary regressions cover iterator construction, iterator advancement, and
MemoryErrorpreservation.Exact-current verification
Exact-head Security Scan and SAST Semgrep succeeded. CI run
31559341595reached the complete Python suite. On Python 3.14 the newtests/test_rubric_iterable_error_boundary.pytests are GREEN; the aggregate result is 5 failed, 3462 passed, 2 skipped.The only five failures are inherited protected-main baseline contract inconsistencies outside this two-file slice:
ACTIVE PRvocabulary expected by its contract;IMPLEMENTED / PLANNED extensionswording;Those failures belong to the existing canonical documentation/fit-statistics correction line. This PR must not reintroduce Python numerical ownership or mutate the sole canonical documentation authority merely to make unrelated aggregate CI green.
Merge boundary
Keep Draft until the protected-main baseline correction integrates. Then regenerate all base-sensitive exact-head checks/reviews on the resulting live base and merge only if the unchanged slice is genuinely gate-clean with zero valid unresolved findings.