Skip to content

test(security): cover LLM-judge JSON nesting depth contract - #768

Merged
seonghobae merged 1 commit into
mainfrom
fix/llm-judge-json-depth-contract
Aug 11, 2026
Merged

test(security): cover LLM-judge JSON nesting depth contract#768
seonghobae merged 1 commit into
mainfrom
fix/llm-judge-json-depth-contract

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Why

#764 landed the nesting-depth guard; this follow-up pins the public constant export, CHANGELOG note, and a regression that proves excessively nested judge JSON fails closed before json.loads recursion risk.

Verification

  • pytest tests/test_llm_judge.py::test_judge_rejects_excessively_nested_json green locally

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a8ecc452-464d-450a-ab2f-69a3272bd13e

📥 Commits

Reviewing files that changed from the base of the PR and between bada084 and 0137c7f.

📒 Files selected for processing (1)
  • python/fast_mlsirm/llm_judge.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Surface the nesting-depth constant in __all__ so callers and regression
tests can pin the fail-closed JSON depth bound without private imports.
@seonghobae
seonghobae force-pushed the fix/llm-judge-json-depth-contract branch from 31002eb to 0137c7f Compare August 11, 2026 19:38
@seonghobae
seonghobae merged commit a891f84 into main Aug 11, 2026
19 checks passed
@seonghobae
seonghobae deleted the fix/llm-judge-json-depth-contract branch August 11, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant