test(inference): refresh Rust observed-information ownership RED on current main - #757
Closed
seonghobae wants to merge 1 commit into
Closed
test(inference): refresh Rust observed-information ownership RED on current main#757seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Superseded by GREEN #758 observed-information ownership. Closing RED test-only refresh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean-lineage replacement for #734 / issue #625
Protected
mainadvanced materially after #734's fail-first evidence and its OpenCode handoff was explicitly bound to old protected main7b57f77747b9a9bd911660c76b1be0ca0dc2d145. Fresh compare proves #734 is now 30 protected-main commits behind and its only unique delta istests/test_observed_information_rust_ownership.py. This Draft recreates that exact ownership RED directly on current protected main without transferring predecessor checks/reviews.Exact identity
8a56d7b1b024e18a5a96a94db4ede1bf6648ead1;9938913de69cefb4c40ca9af3569d6f55be98ed7;tests/test_observed_information_rust_ownership.pyonly.Intentional RED
The tests install unmistakable proposed compiled-core sentinels and require public
observed_information()to return the Rust-owned Hessian matrix and publicsecond_order_test()to return Rust-owned positive-definiteness/eigenvalue evidence. Valid RED must occur after normal Rust/PyO3 package setup and backend resolution because the current public path still computes those numerics in Python. Setup/import/fixture/changelog failure is not evidence.Minimum GREEN
Move dense central finite-difference observed-information/Hessian construction plus result-affecting symmetry semantics and public second-order eigenvalue/positive-definiteness arithmetic into
mlsirm-core; expose the thinnest PyO3 boundary. Python retains bounded input/config validation, immutable marshalling and result transport only; missing/incompatible compiled capability fails closed. Preserve current penalized negative-log-likelihood estimand, packing/order,stepand tolerance/error semantics unless a separately test-first scientific defect proves otherwise. Reassess O(p²) dense memory/evaluation limits from measured resource evidence before acceptance. Add direct Rust↔public parity/property tests, caller immutability, stable non-reflective errors and uncertainty/SE calibration evidence appropriate to the public claim; algebraic parity or correlation alone is insufficient. CPU f64 remains reference; benchmark before GPU.After GREEN add complete rustdoc/docstrings, APA-7 equation/source doctoring and authoritative changelog material, then require exact changed-production statement/branch coverage and one unchanged head passing Python 3.12/3.14, Rust/PyO3, package/reinstall, existing GPU/fuzz, Security Scan, SAST and current-head review/governance gates. Canonical Architecture/TRD/ADR/UML/ERD/traceability remains solely #604/#621.
Keep Draft. Once this replacement is established, #734 is superseded. Advances #625.