Skip to content

test(inference): refresh Rust observed-information ownership RED on current main - #757

Closed
seonghobae wants to merge 1 commit into
mainfrom
test/observed-information-rust-ownership-625-main-20260812
Closed

test(inference): refresh Rust observed-information ownership RED on current main#757
seonghobae wants to merge 1 commit into
mainfrom
test/observed-information-rust-ownership-625-main-20260812

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Clean-lineage replacement for #734 / issue #625

Protected main advanced materially after #734's fail-first evidence and its OpenCode handoff was explicitly bound to old protected main 7b57f77747b9a9bd911660c76b1be0ca0dc2d145. Fresh compare proves #734 is now 30 protected-main commits behind and its only unique delta is tests/test_observed_information_rust_ownership.py. This Draft recreates that exact ownership RED directly on current protected main without transferring predecessor checks/reviews.

Exact identity

  • protected base: 8a56d7b1b024e18a5a96a94db4ede1bf6648ead1;
  • exact source head: 9938913de69cefb4c40ca9af3569d6f55be98ed7;
  • compare to protected main: direct one-commit descendant, ahead 1 / behind 0;
  • changed path: tests/test_observed_information_rust_ownership.py only.

Intentional RED

The tests install unmistakable proposed compiled-core sentinels and require public observed_information() to return the Rust-owned Hessian matrix and public second_order_test() to return Rust-owned positive-definiteness/eigenvalue evidence. Valid RED must occur after normal Rust/PyO3 package setup and backend resolution because the current public path still computes those numerics in Python. Setup/import/fixture/changelog failure is not evidence.

Minimum GREEN

Move dense central finite-difference observed-information/Hessian construction plus result-affecting symmetry semantics and public second-order eigenvalue/positive-definiteness arithmetic into mlsirm-core; expose the thinnest PyO3 boundary. Python retains bounded input/config validation, immutable marshalling and result transport only; missing/incompatible compiled capability fails closed. Preserve current penalized negative-log-likelihood estimand, packing/order, step and tolerance/error semantics unless a separately test-first scientific defect proves otherwise. Reassess O(p²) dense memory/evaluation limits from measured resource evidence before acceptance. Add direct Rust↔public parity/property tests, caller immutability, stable non-reflective errors and uncertainty/SE calibration evidence appropriate to the public claim; algebraic parity or correlation alone is insufficient. CPU f64 remains reference; benchmark before GPU.

After GREEN add complete rustdoc/docstrings, APA-7 equation/source doctoring and authoritative changelog material, then require exact changed-production statement/branch coverage and one unchanged head passing Python 3.12/3.14, Rust/PyO3, package/reinstall, existing GPU/fuzz, Security Scan, SAST and current-head review/governance gates. Canonical Architecture/TRD/ADR/UML/ERD/traceability remains solely #604/#621.

Keep Draft. Once this replacement is established, #734 is superseded. Advances #625.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3695d834-a5b7-48aa-b222-3b05ef54b050

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Superseded by GREEN #758 observed-information ownership. Closing RED test-only refresh.

@seonghobae seonghobae closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant