Skip to content

test(inference): close nonfinite uncertainty review evidence gaps - #729

Closed
seonghobae wants to merge 3 commits into
mainfrom
test/inference-nonfinite-evidence-completeness
Closed

test(inference): close nonfinite uncertainty review evidence gaps#729
seonghobae wants to merge 3 commits into
mainfrom
test/inference-nonfinite-evidence-completeness

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Post-merge review-completeness correction

Protected main at branch creation: 3bc1222bf9552bb74f98cf34c89eba0b8d29c0dc.

PR #725 correctly landed the production behavior: non-finite Hessians fail closed and non-finite covariance diagonals are preserved instead of becoming false zero uncertainty. A valid current-head CodeRabbit review identified two evidence gaps that remained after that protected merge:

  1. the Python/Rust regressions asserted NaN and +∞ but not -∞, despite the public/Rust contract explicitly promising signed-infinity preservation; and
  2. the doctoring cited references without stable links or source-specific rationale for the uncertainty/reporting and floating-point representation decisions.

Bounded correction

  • add symmetric -∞ preservation assertions to public Python↔Rust parity and the Rust unit contract;
  • add stable official source links and source-specific rationale for AERA/APA/NCME uncertainty/interpretation governance, NIST standard-uncertainty guidance, and Rust's primary f64 NaN/±∞ representation documentation;
  • explicitly state that preserving non-finite sentinels is a repository safety/representation decision rather than falsely attributing that exact IEEE-754 policy to the measurement sources.

No production numerical code, estimator semantics, dependencies, workflow, version, or release behavior changes in this slice. The finite-negative-diagonal clamp remains accepted compatibility behavior; changing it would require a separate scientific/API decision.

Require focused inference tests, Rust workspace/PyO3, Python 3.12/3.14 and all ordinary package/security gates on one unchanged head before merge. This closes the still-valid review findings from #725 without reopening the already-merged production correction.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d6d9d327-d83f-4963-8ac6-5621ea7f94bf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Superseded by #730. Fresh comparison shows both branches target the same post-#725 non-finite uncertainty evidence gap. #730 now contains the signed -∞ Rust/Python regressions, current rendered CHANGELOG, and the non-duplicative AERA/NIST/Rust/source-specific doctoring rationale from this branch. No checks or reviews transfer across heads. Closing this Draft to preserve one canonical merge path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant