Skip to content

fix(ata): preflight semantic-range and exclusion controls - #728

Merged
seonghobae merged 5 commits into
mainfrom
test/ata-semantic-range-preflight-683
Aug 11, 2026
Merged

fix(ata): preflight semantic-range and exclusion controls#728
seonghobae merged 5 commits into
mainfrom
test/ata-semantic-range-preflight-683

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Why

Advances and completes draft semantic-range RED. Type-valid but invalid ATA controls (negative seed/counts, min>max, out-of-bank exposure/exclude, hostile exclude coercion) could still reach item-information work after the constraint-map type boundary (#726).

What

  • Non-negative content counts; min cannot exceed max per label
  • Exposure map keys in bank, non-negative counts
  • Exact integer exclude containers without conversion hooks; in-bank only
  • Non-negative seed/exposure_max
  • Fail before item_information_matrix
  • Tests + APA doctoring + changelog fragment (## headings)

Supersedes incomplete RED framing of this draft once product CI is green.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9251fbaf-71ed-4659-ab0d-1fcdc1efd8f7

📥 Commits

Reviewing files that changed from the base of the PR and between 3afb302 and 66d8403.

📒 Files selected for processing (4)
  • docs/changelog.d/683-ata-semantic-range-preflight.md
  • docs/doctoring/ata_constraint_map_validation.md
  • python/fast_mlsirm/ata.py
  • tests/test_ata_semantic_range_preflight.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@opencode-agent address

Take a bounded deterministic release-note writer lease only on Draft #728 if a final refetch still shows exact source head 1a9017d93e256f04ce4a4378ce297c99d264185a and protected main 3afb302ae94e7c996d6c64e6871d35e3c288ddcd; abort without writing if either moved or another writer appears. The production ATA semantic-range/exclusion fix and expanded regressions are already implemented, and exact pre-documentation head f92a58a59866927c34506873de6b7a4585546027 passed CI, Security Scan, and SAST. The branch now also contains updated Python 3.14 trust-boundary doctoring plus authoritative fragment docs/changelog.d/683-ata-semantic-range-preflight.md.

Do only deterministic changelog completion: run python scripts/render_changelog_fragments.py --update CHANGELOG.md, then python scripts/render_changelog_fragments.py --check CHANGELOG.md; run focused pytest -q tests/test_ata_semantic_range_preflight.py tests/test_ata.py tests/test_changelog_fragment_contract.py and git diff --check; commit only the renderer-managed CHANGELOG.md synchronization if those checks pass. Do not alter ATA production code/tests/doctoring/fragment semantics, dependencies, workflows, credentials, branch protection, version/release state, or canonical #604 docs. After the renderer commit, stop writing this branch so the maintainer loop can refetch exact-head/current-base CI and review evidence.

@seonghobae seonghobae changed the title test(ata): fail first on remaining semantic-range controls fix(ata): preflight semantic-range and exclusion controls Aug 11, 2026
@seonghobae
seonghobae force-pushed the test/ata-semantic-range-preflight-683 branch from 1a9017d to 66d8403 Compare August 11, 2026 11:28
@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 11:30
@seonghobae
seonghobae merged commit bb30b19 into main Aug 11, 2026
35 checks passed
@seonghobae
seonghobae deleted the test/ata-semantic-range-preflight-683 branch August 11, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant