test(fitstats): fail closed without Rust after tail merge - #720
test(fitstats): fail closed without Rust after tail merge#720seonghobae wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by GREEN implementation #723 (fail-closed chi2_sf/BH without pure-Python fallback). |
Post-integration ownership correction for #627
Protected
mainat branch creation and final pre-PR refetch:640de7dd39d944749b92b1a88bafa8e1787a0847.PR #646 merged Rust implementations for chi-square survival probability and Benjamini–Hochberg decisions, but fresh protected-main inspection shows both public Python functions still silently execute their complete historical Python/NumPy numerical implementations whenever
_core_module()returnsNoneor lacks the new entrypoint. That leaves two ordinary production numerical owners and does not satisfy #627's Rust-first fail-closed contract.This Draft adds only the smallest fail-first production-boundary regressions:
chi2_sf()must raise a stable package-owned capability error when the compiled core is absent;benjamini_hochberg()must do the same; andCurrent protected main is expected to fail all three tests by returning Python-computed results. Setup/import/fixture failure is not valid RED.
Minimum GREEN after exact RED proof
RuntimeErrorfamily when absent.Do not add SciPy, change fit-statistical formulas, dependencies/workflows/version/release, or canonical #604 docs. Keep Draft through RED→GREEN. Advances #627.