🛡️ Sentinel: [MEDIUM] Fix subprocess timeout DoS risk

[seonghobae]

🚨 Severity: MEDIUM
💡 Vulnerability: Missing timeout on subprocess.run calls can lead to indefinite hangs and resource exhaustion (DoS).
🎯 Impact: Subprocesses that hang or wait for input indefinitely could block the main CI/CD or automation scripts forever, leading to pipeline stalls or resource exhaustion.
🔧 Fix: Added explicit timeout=60 to general subprocess calls and timeout=1800 to known long-running test and release acceptance subprocess calls across 9 Python scripts in the scripts/ directory.
✅ Verification: Ran uv run ruff check to ensure formatting/linting, ran tests to ensure build tooling was not broken. Evaluated with cat scripts/*.py | grep "subprocess.run" to ensure all usages now define a timeout.

---

PR created automatically by Jules for task 1554865628348086941 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: be19755f-13b2-4060-8d45-de702013b77d

📥 Commits

Reviewing files that changed from the base of the PR and between a7be9eb and 3cd0d1c.

📒 Files selected for processing (9)

• scripts/build_benchmark_report.py
• scripts/build_buyer_packet.py
• scripts/build_commercial_release.py
• scripts/build_figma_evidence_sync.py
• scripts/build_pr_queue_governance.py
• scripts/build_procurement_due_diligence.py
• scripts/build_release_evidence_index.py
• scripts/release_acceptance.py
• scripts/run_ignored_rust_shard.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[opencode-agent]

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 3cd0d1cb37ba4c74bc03f80a19b292edd40a4d09.

• Head SHA: 3cd0d1cb37ba4c74bc03f80a19b292edd40a4d09

• Workflow run: 31426128020

• Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (9 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (9 files)"]
  R1 --> V1["required checks"]

Loading

[opencode-agent]

OpenCode Review Overview

• Head SHA: 3cd0d1cb37ba4c74bc03f80a19b292edd40a4d09
• Workflow run: 31426128020
• Workflow attempt: 1
• Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 3cd0d1cb37ba4c74bc03f80a19b292edd40a4d09.

• Head SHA: 3cd0d1cb37ba4c74bc03f80a19b292edd40a4d09

• Workflow run: 31426128020

• Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (9 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (9 files)"]
  R1 --> V1["required checks"]

Loading

[seonghobae]

Closing this broad blanket-timeout PR as superseded/architecturally invalid for the accepted #555 reliability contract. Exact current diff touches nine scripts, but six of those paths already have narrower active owners with operation-specific semantics: build_benchmark_report.py #666, build_buyer_packet.py #669, build_procurement_due_diligence.py #670, release_acceptance.py #667, run_ignored_rust_shard.py #578, and build_pr_queue_governance.py #657. #555 explicitly rejects one blanket 60-second timeout, requires operation-class deadlines, explicit TimeoutExpired handling, non-reflective failure evidence, and process-group cleanup where applicable. This PR instead adds generic 60/1800/3600 values and leaves several _source_commit() call sites broadly swallowing timeout into "unknown", so merging it would conflict with the accepted fail-closed design and race active path owners. The remaining uncovered scripts (build_commercial_release.py, build_figma_evidence_sync.py, build_release_evidence_index.py) remain under #555 for later disjoint test-first slices; useful intent is preserved there rather than lost.

[google-labs-jules]

Closing this broad blanket-timeout PR as superseded/architecturally invalid for the accepted #555 reliability contract. Exact current diff touches nine scripts, but six of those paths already have narrower active owners with operation-specific semantics: build_benchmark_report.py #666, build_buyer_packet.py #669, build_procurement_due_diligence.py #670, release_acceptance.py #667, run_ignored_rust_shard.py #578, and build_pr_queue_governance.py #657. #555 explicitly rejects one blanket 60-second timeout, requires operation-class deadlines, explicit TimeoutExpired handling, non-reflective failure evidence, and process-group cleanup where applicable. This PR instead adds generic 60/1800/3600 values and leaves several _source_commit() call sites broadly swallowing timeout into "unknown", so merging it would conflict with the accepted fail-closed design and race active path owners. The remaining uncovered scripts (build_commercial_release.py, build_figma_evidence_sync.py, build_release_evidence_index.py) remain under #555 for later disjoint test-first slices; useful intent is preserved there rather than lost.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.