Skip to content

🧹 Code health: use macro to simplify Python function registration - #599

Closed
seonghobae wants to merge 1 commit into
mainfrom
code-health-macro-registration-14802516189082014159
Closed

🧹 Code health: use macro to simplify Python function registration#599
seonghobae wants to merge 1 commit into
mainfrom
code-health-macro-registration-14802516189082014159

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

🎯 What: Refactored fast_mlsirm_core to use a register_functions! macro for PyO3 function registration.
💡 Why: The original function had nearly 200 lines of repetitive m.add_function(wrap_pyfunction!(..., m)?)?; calls. The macro compresses this into a clean, declarative list, drastically improving readability and maintainability.
✅ Verification: Ran cargo test on fast-mlsirm-py to verify Rust compilation and logic, and uv run pytest tests/test_backend.py to ensure PyO3 bindings continue to function perfectly.
✨ Result: fast_mlsirm_core is much easier to read and append to, eliminating boilerplate without altering any runtime behavior.


PR created automatically by Jules for task 14802516189082014159 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 980f8514-568b-476f-adb9-c0982d768c59

📥 Commits

Reviewing files that changed from the base of the PR and between 4d910ed and 266a422.

📒 Files selected for processing (3)
  • crates/fast-mlsirm-py/src/bifactor_bindings.rs
  • crates/fast-mlsirm-py/src/lib.rs
  • crates/fast-mlsirm-py/src/rotation_bindings.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Closing without merge. Exact head 266a422a434e7e55e9dd5b6902684bcc9adb4e13 rewrites the entire critical PyO3 registration surface into a macro but adds no registration-completeness contract that independently proves every exported function remains present, uniquely registered, and discoverable from the installed wheel. The branch also includes unrelated formatter changes in bifactor/rotation bindings and has no authoritative changelog evidence. With active binding work in #579 and a large product queue, a 196-line add/delete bootstrap refactor creates review/conflict risk without buyer-visible behavior. Reconsider only as a dedicated current-main refactor with generated/export inventory parity, duplicate/missing registration regressions, installed-wheel smoke evidence, and no unrelated formatting. No checks or reviews transfer.

@seonghobae seonghobae closed this Aug 9, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing without merge. Exact head 266a422a434e7e55e9dd5b6902684bcc9adb4e13 rewrites the entire critical PyO3 registration surface into a macro but adds no registration-completeness contract that independently proves every exported function remains present, uniquely registered, and discoverable from the installed wheel. The branch also includes unrelated formatter changes in bifactor/rotation bindings and has no authoritative changelog evidence. With active binding work in #579 and a large product queue, a 196-line add/delete bootstrap refactor creates review/conflict risk without buyer-visible behavior. Reconsider only as a dedicated current-main refactor with generated/export inventory parity, duplicate/missing registration regressions, installed-wheel smoke evidence, and no unrelated formatting. No checks or reviews transfer.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant