Skip to content

๐Ÿงน ์ฝ”๋“œ ์ƒํƒœ ๊ฐœ์„ : ๋ชจํ˜ธํ•œ ๋ณ€์ˆ˜๋ช… 'l'์„ 'log_lik_dtx'๋กœ ๋ณ€๊ฒฝ - #594

Closed
seonghobae wants to merge 1 commit into
mainfrom
jules-12480561204951314711-eca08974
Closed

๐Ÿงน ์ฝ”๋“œ ์ƒํƒœ ๊ฐœ์„ : ๋ชจํ˜ธํ•œ ๋ณ€์ˆ˜๋ช… 'l'์„ 'log_lik_dtx'๋กœ ๋ณ€๊ฒฝ#594
seonghobae wants to merge 1 commit into
mainfrom
jules-12480561204951314711-eca08974

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

๐ŸŽฏ What:
Renamed the ambiguous variable l to log_lik_dtx in python/fast_mlsirm/estimators/marginal.py.

๐Ÿ’ก Why:
The single-letter variable l was uninformative and harmed readability. Renaming it to log_lik_dtx explicitly clarifies its role as the per-person log-likelihood computed across the dimension (d), trait (t), and covariates (x) spatial components, improving long-term maintainability.

โœ… Verification:

  • The Python formatter and linter ran successfully.
  • Tests spanning test_estimator_marginal.py, test_cov_e_marginal.py, and test_cov_f_marginal.py pass without regression.
  • The complete Rust and Python (tests/) test suites pass successfully.

โœจ Result:
Enhanced readability and self-documentation of complex core log-likelihood logic.


PR created automatically by Jules for task 12480561204951314711 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
โš™๏ธ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7cdbeda4-84a7-4081-bf21-66207cd0e712

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 4d910ed and 052cce9.

๐Ÿ“’ Files selected for processing (1)
  • python/fast_mlsirm/estimators/marginal.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Closing this branch as superseded and non-integrable in its current form. Exact protected main is 4d910ed650f384ff882c8b5fba6a8b08fd532236; exact head 052cce926d9ecda6af7deebed7f3d753fd2c3032 is one commit ahead and changes only python/fast_mlsirm/estimators/marginal.py, but the intended local rename is coupled to 311 lines of whole-file formatter churn. PR #595 independently proposes the same single-letter-variable cleanup with a competing name, while active #564 and #587 already own substantive changes to this numerical fallback file. Retaining either rename branch now would create unnecessary ancestry/conflict risk without a focused regression, authoritative changelog evidence, or buyer-visible behavior. The cleanup can be reconsidered after the earlier marginal.py work integrates as a minimal, independently tested diff; no checks or review evidence from this branch should transfer.

@google-labs-jules

Copy link
Copy Markdown

Closing this branch as superseded and non-integrable in its current form. Exact protected main is 4d910ed650f384ff882c8b5fba6a8b08fd532236; exact head 052cce926d9ecda6af7deebed7f3d753fd2c3032 is one commit ahead and changes only python/fast_mlsirm/estimators/marginal.py, but the intended local rename is coupled to 311 lines of whole-file formatter churn. PR #595 independently proposes the same single-letter-variable cleanup with a competing name, while active #564 and #587 already own substantive changes to this numerical fallback file. Retaining either rename branch now would create unnecessary ancestry/conflict risk without a focused regression, authoritative changelog evidence, or buyer-visible behavior. The cleanup can be reconsidered after the earlier marginal.py work integrates as a minimal, independently tested diff; no checks or review evidence from this branch should transfer.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant