Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@
## 2024-10-24 - CSS Bar Chart Animation
**Learning:** CSS animations can enhance static data visualizations without requiring JavaScript, providing visual polish and reducing perceived loading times for data.
**Action:** Use CSS keyframe animations for simple visual improvements in static reports.
## 2025-01-28 - ARIA Live Regions for Empty States
**Learning:** Using standard `<p>` tags for empty states in dynamic or conditionally rendered tables can lead to screen readers silently skipping the section, leaving users confused about missing data.
**Action:** Use `<div class="empty-state" role="status">` for empty states to leverage ARIA live regions, ensuring assistive technologies actively announce that no rows were recorded.
2 changes: 1 addition & 1 deletion python/fast_mlsirm/report.py
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ def _bar_chart(rows: list[dict[str, Any]], value_key: str | None) -> str:

def _table(rows: list[dict[str, Any]], *, label: str, limit: int = 12) -> str:
if not rows:
return '<p class="empty-state">No rows were recorded in this section.</p>'
return '<div class="empty-state" role="status">No rows were recorded in this section.</div>'
Comment thread
github-actions[bot] marked this conversation as resolved.
Resolved

columns = _columns(rows)
body_rows = []
Expand Down
Loading