⚡ Bolt: [성능 개선] MMLE M-step에서 아이템 순회 루프 완전 벡터화로 성능 향상 - #168
Conversation
This commit replaces the `for i in range(n_items)` loop within the Expectation-Maximization M-step (in `fit_mmle_2pl`) with fully vectorized NumPy matrix operations. By using an `active_mask` to track unconverged parameters and singular Hessians simultaneously across all items, it completely bypasses massive Python loop overhead. Tests show an execution time reduction from 0.55s to 0.3s (~45% speedup) for N=5000, J=100.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head5cb173767df6e8c038cd8bf0a07e7e957e0c2b43. -
Head SHA:
5cb173767df6e8c038cd8bf0a07e7e957e0c2b43 -
Workflow run: 29444311369
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: mmle.py"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: mmle.py"]
R1 --> V1["required checks"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
|
Resolved `clippy::needless_range_loop` warnings in `crates/mlsirm-core/src/mmle.rs` introduced by standard iteration logic in the Expectation-Maximization step. Replaced raw index access loops with safe `.iter()`, `.iter_mut()`, and `.zip()` constructs.
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headb318c254428769ba735125cb6fb7bed61f7e4ea8. -
Head SHA:
b318c254428769ba735125cb6fb7bed61f7e4ea8 -
Workflow run: 29445119273
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 2
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
|
중복 정리: 배경: 2026-07-14 이후 조직 coverage-evidence 인프라 문제로 모든 PR이 REQUEST_CHANGES 상태였습니다(인프라 수정: ContextualWisdomLab/.github#611). 필요 시 재오픈 가능합니다. Generated by Claude Code |
Understood. Acknowledging that this work is a duplicate of #162 and is now obsolete. Stopping work on this task. |
1 participant
💡 What:
fast_mlsirm/estimators/mmle.py의fit_mmle_2pl함수 내 M-step에서 아이템 차원에 대한 Python 루프(for i in range(n_items):)를 제거하고,active_mask를 활용하여 모든 아이템에 대해 동시에 Newton-Raphson 업데이트를 수행하도록 코드를 완전 벡터화(fully vectorized)했습니다.@)을 사용해 성능을 대폭 향상시켰습니다..jules/bolt.md)에 문서화했습니다.🎯 Why:
📊 Impact:
🔬 Measurement:
a,b,theta)를 출력하는지 확인했으며,python -m pytest tests통과로 정확성을 검증했습니다.PR created automatically by Jules for task 8988808738592528922 started by @seonghobae