feat(interaction-map): own residual factorization in Rust - #1387
Merged
seonghobae merged 45 commits intoAug 25, 2026
Merged
Conversation
PRs merged after the v0.8.0 release-cut PR (#966) added new docs/changelog.d fragments without re-running the renderer, and the already-released release-0.8.0-cut.md fragment was left in place, duplicating the 0.8.0 section under Unreleased. Delete the stale fragment and re-render so render_changelog_fragments.py --check passes again, unblocking the v0.8.0 release-tag dispatch.
Ten more PRs merged into main after this fix's original commit, each adding docs/changelog.d fragments without re-running the renderer. Re-run render_changelog_fragments.py --update so --check passes again and the v0.8.0 release-tag dispatch is no longer blocked.
* test(dif): expose executable logistic controls * fix(dif): normalize controls before data and Rust * fix(dif): install hardened public DIF adapters * docs(changelog): record logistic DIF control boundary * docs(doctoring): trace logistic DIF control trust boundary * fix(changelog): classify logistic DIF control boundary --------- Co-authored-by: Claude <noreply@anthropic.com>
…rrent-review-971 Resolves the changelog/init-module conflicts introduced by main's independent progress since this branch diverged: - CHANGELOG.md: regenerated the authoritative Unreleased block via scripts/render_changelog_fragments.py --update so it reflects every currently-present docs/changelog.d fragment (including this branch's 958-logistic-dif-control-boundary.md) without reintroducing the already-released, already-removed release-0.8.0-cut.md duplicate. - python/fast_mlsirm/__init__.py: combined this branch's DIF control-safety installation with main's independently added exposure array/flexilevel control-safety installation.
…rappers safe_logistic_dif and safe_logistic_dif_purified normalized max_iter with minimum=0, admitting zero at the Python boundary even though the native logistic_sweep (crates/mlsirm-core/src/dif.rs) rejects max_iter == 0 with "max_iter must be >= 1", and the module's own doctoring already documented max_iter as a positive usize control. A zero cap therefore cleared control validation, materialized caller response/group arrays, and dispatched to the compiled core before failing there instead of being rejected up front (Devin AI review finding on PR #998). Raise the minimum to 1 for both wrappers so the rejection happens before data materialization or core discovery, matching the documented and native domains. Updated the compatibility regressions accordingly: the former zero-iteration dispatch proofs now use the true minimum (1), and new regressions prove max_iter=0 is rejected before core discovery for both logistic_dif and logistic_dif_purified.
…rrent-review-971 Pulls in #1324 (grm-recovery toolchain pin + metadata scalar test realignment), now merged to main, resolving the two pre-existing CI regressions this branch had been carrying independently of its own diff. Regenerated CHANGELOG.md via scripts/render_changelog_fragments.py --update to resolve the conflict from the merged fragment set.
# Conflicts: # python/fast_mlsirm/__init__.py
Contributor
📝 WalkthroughWalkthroughThe change adds a Rust-backed residual interaction-map implementation with complete-case filtering and Gabriel factorization. It exposes the results through a validated Python API, documents the contract, and adds core and Python tests. ChangesResidual Interaction-Map Contract
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🟠 High · up to The new interaction-map API accepts unbounded axis_count values, and an extreme input can cause an impossible allocation that aborts the host process; validation is needed before merge. Two RUF002 lint warnings also remain. Sequence Diagram(s)sequenceDiagram
participant PythonCaller
participant PythonWrapper as fast_mlsirm.interaction_map
participant RustBinding as fast-mlsirm-py
participant RustCore as mlsirm_core::interaction_map
PythonCaller->>PythonWrapper: Call residual_interaction_map
PythonWrapper->>RustBinding: Pass validated arrays and axis_count
RustBinding->>RustCore: Compute residual interaction map
RustCore-->>RustBinding: Return coordinates and diagnostics
RustBinding-->>PythonWrapper: Return result data
PythonWrapper-->>PythonCaller: Return ResidualInteractionMap
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 7 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ntract' into feat/residual-interaction-map-contract # Conflicts: # tests/test_interaction_map.py
…urrent-review-971 fix(release,dif): resync changelog and harden logistic controls
…ns' into feat/residual-interaction-map-contract
…ntract' into feat/residual-interaction-map-contract # Conflicts: # python/fast_mlsirm/__init__.py
seonghobae
changed the base branch from
main
to
feat/public-polytomous-predictions
August 25, 2026 11:20
seonghobae
merged commit Aug 25, 2026
cbb0df1
into
feat/public-polytomous-predictions
22 of 23 checks passed
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1388.
Closes #1389.
Closes #1390.
Contract
Moves reusable residual interaction-map computation into fast-mlsirm. Rust owns complete-case admission, Gabriel symmetric factorization, coordinates, singular values, axis inertia, reconstruction, distance, unexplained residual, and the algebraic cross term. Consumers retain identifiers, authorization, persistence, selection, and UI.
No weights, thresholds, or model scores are invented.
axis_countis consumer-supplied.NaNis reserved for observed-response missingness; observed infinity is invalid and fitted model expectations must be finite evidence.Test-first hardening lineage
Evidence/resource admission — #1388
4f32560a1459f75792717f8a89bea66b4ebb4e95-> GREEN0080788ecc1f11dbeb53cff98ef977871d90f3e7: callback-free/lossless evidence and control admission plus 20,000,000-cell logical/coordinate envelopes.405203c472d7c26599783cdb80205d61143af578-> GREENea33483c673bbb5d1d3407af3463f6320cb91b78: same logical/coordinate ceilings in Rust plus 128 MiB peak symmetric-eigendecomposition workspace ceiling.27dd0ae13d6b065dd4dcdb07a6ce795dc2c99c7a+ public proof1f3e816e4b42bc4d4f03089606649f654ad5a93f+ governed evidence12bd0342a2b3525b8497998be24aa06226e90e37.Shape-consistent empty complete-case result — #1389
2cf7c3d665b8a86534aab38287e6b6c372b621a4.ef09fa71cdce4e2ce9b38dd9cb9db23c9368fcdf-> GREENea84f6766f0f09a38372f201613ceb1f03006b4e.1d27c71c23f7b93a9af657fda0ec6172a996fa98.The GREEN intentionally does not add a maximal-complete-submatrix selector and does not alter non-empty factorization arithmetic.
Missingness / model-evidence parity — #1390
Current-source review found that the same finite-cell predicate was used for observed responses and fitted expectations. That silently reclassified
expected=NaNas response missingness and could change the analyzed rectangle rather than report invalid model evidence. Direct Rust also treated observed infinity as missing although the public contract rejects infinity.df72c9e7fa6416e42a1aebd2cde56d2c82dc5771:expected=NaNfails before compiled-core dispatch while observedNaNremains admissible.070ce177ca565556cdf79e742cc3cd28e8e75abf-> Python GREEN94c0243af1e269269d5c4b23982cbb605b4f7185-> Rust GREEN7805a79c4cb9182e70fecc61f3fffef920938f4b.4cec5b64af444b52e76d1553e72f69eb084d0a52-> GREENa317ccfb1957fd96c0e5c54f073d9f0384c46ee6: direct Rust now preserves the sameNaN-only missingness semantics instead of turning infinity into a dropped cell.f9e80c1565a8244ed7543e9706d9628299cc3f23.Scientific basis
Scientific ownership
No production psychometric arithmetic moved to Python. Gabriel factorization, singular values, symmetric coordinates, reconstruction, distance, unexplained residual and cross-term arithmetic remain Rust-owned; Python changes are validation, lossless marshalling, bounded materialization, result shaping and tests.
Fresh integration boundary
Protected
mainadvanced normally during this invocation to897e1c7b2e64d74066cdc7cb460f610c625b39d2via #998. The intervening main delta is logistic-DIF/release work and does not modify interaction-map Rust/Python/tests, though both lineages touch sharedCHANGELOG.md/ package-export context. Fresh ancestry showed this branch diverged from merge based77505e9dc8eee5780bf354e13dd4f4bf83df453; GitHub currently reports it mergeable. Main movement is not a writer lease; require fresh merge-result/base-sensitive evidence before landing.Exact source/test/evidence head immediately before this body update:
f9e80c1565a8244ed7543e9706d9628299cc3f23, open and non-Draft. Every predecessor-head workflow/review is historical after these writes. Require fresh exact-current-head repository CI, Security Scan, SAST Semgrep, CodeQL, ClusterFuzzLite, all applicable protected-central coverage/review/package/fuzz/SBOM/provenance/dependency evidence, resolved conversations and independent approvals before merge. No self-approval, review dismissal, gate weakening, force update, destructive rebase or Python numerical substitute is used.