๐จ Palette: ์คํฌ๋กค ์์ ๋ฐ ์์ฝ ํ๊ทธ์ ๋ง์ฐ์ค ํด๋ฆญ ์ ํฌ์ปค์ค ๋ง ์ ๊ฑฐ - #1143
๐จ Palette: ์คํฌ๋กค ์์ ๋ฐ ์์ฝ ํ๊ทธ์ ๋ง์ฐ์ค ํด๋ฆญ ์ ํฌ์ปค์ค ๋ง ์ ๊ฑฐ#1143seonghobae wants to merge 3 commits into
Conversation
HTML ๋ณด๊ณ ์ ๋ด `.table-scroll`, `<pre>`, `<summary>` ์์๊ฐ ๋ง์ฐ์ค๋ก ํด๋ฆญ๋ ๋ ๋ฐ์ํ๋ ๋ถํ์ํ ๊ธฐ๋ณธ ๋ธ๋ผ์ฐ์ ํฌ์ปค์ค ์์๋ผ์ธ์ ์ ๊ฑฐํ์ฌ ์๊ฐ์ ์์ฑ๋๋ฅผ ๋์์ต๋๋ค. ํค๋ณด๋ ๋ค๋น๊ฒ์ด์ ์ ํ์ํ `:focus-visible` ์์ฑ์ ๊ทธ๋๋ก ์ ์ง๋ฉ๋๋ค.
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 34 minutes Limit details: Youโve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review detailsโ๏ธ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ๐ Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review disposition at exact head
The CSS change remains bounded to report accessibility behavior. |
Acknowledged. I have reverted the |
HTML ๋ณด๊ณ ์ ๋ด `.table-scroll`, `<pre>`, `<summary>` ์์๊ฐ ๋ง์ฐ์ค๋ก ํด๋ฆญ๋ ๋ ๋ํ๋๋ ๊ธฐ๋ณธ ํฌ์ปค์ค ๋ผ์ธ์ CSS `:focus { outline: none; }`๋ฅผ ์ถ๊ฐํ์ฌ ์ ๊ฑฐํ์ต๋๋ค. ํค๋ณด๋ ๋ด๋น๊ฒ์ด์
์ ์ํ `:focus-visible` ์ค์ ์ ์ด์ ๊ณผ ๋์ผํ๊ฒ ์ ์ง๋์ด ์น ์ ๊ทผ์ฑ์ ํด์น์ง ์๊ณ ๋ง์ฐ์ค ์ฌ์ฉ์์ ์๊ฐ์ UX๊ฐ ๊ฐ์ ๋์์ต๋๋ค.
|
Current-head reconciliation at exact head
The PR remains on the normal protected auto-merge path. |
| .table-scroll:focus, pre:focus { outline: none; } | ||
| .table-scroll:focus-visible, pre:focus-visible { outline: 3px solid Highlight; outline-offset: 3px; } |
There was a problem hiding this comment.
๐ Info: Focus suppression pattern differs from the main element
The new .table-scroll:focus, pre:focus { outline: none; } paired with the :focus-visible rule below drops the keyboard focus ring on user agents lacking :focus-visible support, since the invalid :focus-visible selector list is discarded. The main element in the same stylesheet deliberately uses main:focus:not(:focus-visible) to keep a fallback (enforced by tests/test_scoring_essay_report_pointer_focus.py:11-12). The container :focus { outline: none; } form is the tested convention elsewhere (tests/test_report_focus_contrast.py:55-56), so this matches existing behavior.
Was this helpful? React with ๐ or ๐ to provide feedback.
Acknowledged. Thanks for the verification. |
|
Closing as superseded by the existing report-surface writers after adopting the compatible intent without the blanket-focus selector. Fresh comparison shows:
#1143's blanket |
Pull request was closed
Understood. Acknowledging that this work is now obsolete and superseded by the correct modality-safe |
๐ก What: HTML ๋ฆฌํฌํธ ์์ฑ ์คํฌ๋ฆฝํธ(
report.py,report_html.py) ๋ด์ ์๋ ์คํฌ๋กค ๊ฐ๋ฅํ ์์ ๋ฐ<summary>์์๊ฐ ๋ง์ฐ์ค๋ก ํด๋ฆญ๋ ๋ ๋ํ๋๋ ๊ธฐ๋ณธ ํฌ์ปค์ค ๋ง์ ์จ๊ธฐ๋๋ก CSS๋ฅผ ์ ๋ฐ์ดํธํ์ต๋๋ค.๐ฏ Why: ํ ์ด๋ธ๊ณผ ์ฝ๋ ๋ธ๋ก์ ๊ฐ๋ก ์คํฌ๋กค์ ์ํด
tabindex="0"์์ฑ์ด ์ถ๊ฐ๋๋ฉด์, ์ฌ์ฉ์๊ฐ ์คํฌ๋กค์ ์ํด ํด๋ฆญํ ๋๋ง๋ค ๊ฐํ ํฌ์ปค์ค ๋ผ์ธ์ด ์๊ฒจ ๊ฑฐ์ฌ๋ฆฌ๋ UX ๋ฌธ์ ๊ฐ ๋ฐ์ํ์ต๋๋ค.๐ธ Before/After: ๋ง์ฐ์ค ํด๋ฆญ ์ ์์ ์ฃผ๋ณ์ ๋ถํ์ํ ํ ๋๋ฆฌ๊ฐ ์ฌ๋ผ์ก์ต๋๋ค.
โฟ Accessibility:
:focus-visible์คํ์ผ์:focus์คํ์ผ ๋ค์ ๋ช ์ํจ์ผ๋ก์จ, ํค๋ณด๋ ๋ค๋น๊ฒ์ด์ ์์๋ ์๊ฐ์ ํฌ์ปค์ค ๋ผ์ธ์ด ์จ์ ํ ์ ์ง๋ฉ๋๋ค.PR created automatically by Jules for task 478984360516344947 started by @seonghobae