Skip to content

๐ŸŽจ Palette: ์Šคํฌ๋กค ์š”์†Œ ๋ฐ ์š”์•ฝ ํƒœ๊ทธ์˜ ๋งˆ์šฐ์Šค ํด๋ฆญ ์‹œ ํฌ์ปค์Šค ๋ง ์ œ๊ฑฐ - #1143

Closed
seonghobae wants to merge 3 commits into
mainfrom
palette/remove-mouse-focus-rings-478984360516344947
Closed

๐ŸŽจ Palette: ์Šคํฌ๋กค ์š”์†Œ ๋ฐ ์š”์•ฝ ํƒœ๊ทธ์˜ ๋งˆ์šฐ์Šค ํด๋ฆญ ์‹œ ํฌ์ปค์Šค ๋ง ์ œ๊ฑฐ#1143
seonghobae wants to merge 3 commits into
mainfrom
palette/remove-mouse-focus-rings-478984360516344947

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

๐Ÿ’ก What: HTML ๋ฆฌํฌํŠธ ์ƒ์„ฑ ์Šคํฌ๋ฆฝํŠธ(report.py, report_html.py) ๋‚ด์— ์žˆ๋Š” ์Šคํฌ๋กค ๊ฐ€๋Šฅํ•œ ์š”์†Œ ๋ฐ <summary> ์š”์†Œ๊ฐ€ ๋งˆ์šฐ์Šค๋กœ ํด๋ฆญ๋  ๋•Œ ๋‚˜ํƒ€๋‚˜๋Š” ๊ธฐ๋ณธ ํฌ์ปค์Šค ๋ง์„ ์ˆจ๊ธฐ๋„๋ก CSS๋ฅผ ์—…๋ฐ์ดํŠธํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Why: ํ…Œ์ด๋ธ”๊ณผ ์ฝ”๋“œ ๋ธ”๋ก์˜ ๊ฐ€๋กœ ์Šคํฌ๋กค์„ ์œ„ํ•ด tabindex="0" ์†์„ฑ์ด ์ถ”๊ฐ€๋˜๋ฉด์„œ, ์‚ฌ์šฉ์ž๊ฐ€ ์Šคํฌ๋กค์„ ์œ„ํ•ด ํด๋ฆญํ•  ๋•Œ๋งˆ๋‹ค ๊ฐ•ํ•œ ํฌ์ปค์Šค ๋ผ์ธ์ด ์ƒ๊ฒจ ๊ฑฐ์Šฌ๋ฆฌ๋Š” UX ๋ฌธ์ œ๊ฐ€ ๋ฐœ์ƒํ–ˆ์Šต๋‹ˆ๋‹ค.
๐Ÿ“ธ Before/After: ๋งˆ์šฐ์Šค ํด๋ฆญ ์‹œ ์š”์†Œ ์ฃผ๋ณ€์— ๋ถˆํ•„์š”ํ•œ ํ…Œ๋‘๋ฆฌ๊ฐ€ ์‚ฌ๋ผ์กŒ์Šต๋‹ˆ๋‹ค.
โ™ฟ Accessibility: :focus-visible ์Šคํƒ€์ผ์„ :focus ์Šคํƒ€์ผ ๋’ค์— ๋ช…์‹œํ•จ์œผ๋กœ์จ, ํ‚ค๋ณด๋“œ ๋„ค๋น„๊ฒŒ์ด์…˜ ์‹œ์—๋Š” ์‹œ๊ฐ์  ํฌ์ปค์Šค ๋ผ์ธ์ด ์˜จ์ „ํžˆ ์œ ์ง€๋ฉ๋‹ˆ๋‹ค.


PR created automatically by Jules for task 478984360516344947 started by @seonghobae


Open in Devin Review

HTML ๋ณด๊ณ ์„œ ๋‚ด `.table-scroll`, `<pre>`, `<summary>` ์š”์†Œ๊ฐ€ ๋งˆ์šฐ์Šค๋กœ ํด๋ฆญ๋  ๋•Œ ๋ฐœ์ƒํ•˜๋Š” ๋ถˆํ•„์š”ํ•œ ๊ธฐ๋ณธ ๋ธŒ๋ผ์šฐ์ € ํฌ์ปค์Šค ์•„์›ƒ๋ผ์ธ์„ ์ œ๊ฑฐํ•˜์—ฌ ์‹œ๊ฐ์  ์™„์„ฑ๋„๋ฅผ ๋†’์˜€์Šต๋‹ˆ๋‹ค. ํ‚ค๋ณด๋“œ ๋„ค๋น„๊ฒŒ์ด์…˜ ์‹œ ํ•„์š”ํ•œ `:focus-visible` ์†์„ฑ์€ ๊ทธ๋Œ€๋กœ ์œ ์ง€๋ฉ๋‹ˆ๋‹ค.
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Limit details: Youโ€™ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
โš™๏ธ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f677f5e5-ac7e-497f-a186-4366ac87a683

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 04d0bc2 and baa5c6f.

๐Ÿ“’ Files selected for processing (2)
  • python/fast_mlsirm/report.py
  • python/fast_mlsirm/scoring/essay/report_html.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Review disposition at exact head 29f7c04918d8724369e6c065d81b7ad8898561d1:

  • Resolved Devin finding discussion_r3828245655: removed the PR-only .Jules/palette.md addition; canonical learnings remain in lowercase .jules/, and the pre-existing user working-copy edit was not staged or changed.
  • Added focused regression assertions for mouse-focus suppression and preserved :focus-visible keyboard indicators.
  • Verification: 27 focused tests passed; Ruff passed; interrogate 100% for changed production modules; git diff --check passed.

The CSS change remains bounded to report accessibility behavior.

@seonghobae
seonghobae enabled auto-merge (squash) August 21, 2026 07:39
@google-labs-jules

Copy link
Copy Markdown

Review disposition at exact head 29f7c04918d8724369e6c065d81b7ad8898561d1:

  • Resolved Devin finding discussion_r3828245655: removed the PR-only .Jules/palette.md addition; canonical learnings remain in lowercase .jules/, and the pre-existing user working-copy edit was not staged or changed.
  • Added focused regression assertions for mouse-focus suppression and preserved :focus-visible keyboard indicators.
  • Verification: 27 focused tests passed; Ruff passed; interrogate 100% for changed production modules; git diff --check passed.

The CSS change remains bounded to report accessibility behavior.

Acknowledged. I have reverted the .Jules/palette.md modifications from the staged area to ensure that the user's working-copy and canonical PR logs remain separate and that the PR strictly bounds itself to the targeted CSS accessibility changes.

HTML ๋ณด๊ณ ์„œ ๋‚ด `.table-scroll`, `<pre>`, `<summary>` ์š”์†Œ๊ฐ€ ๋งˆ์šฐ์Šค๋กœ ํด๋ฆญ๋  ๋•Œ ๋‚˜ํƒ€๋‚˜๋Š” ๊ธฐ๋ณธ ํฌ์ปค์Šค ๋ผ์ธ์„ CSS `:focus { outline: none; }`๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค. ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜์„ ์œ„ํ•œ `:focus-visible` ์„ค์ •์€ ์ด์ „๊ณผ ๋™์ผํ•˜๊ฒŒ ์œ ์ง€๋˜์–ด ์›น ์ ‘๊ทผ์„ฑ์„ ํ•ด์น˜์ง€ ์•Š๊ณ  ๋งˆ์šฐ์Šค ์‚ฌ์šฉ์ž์˜ ์‹œ๊ฐ์  UX๊ฐ€ ๊ฐœ์„ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head reconciliation at exact head baa5c6f675a26f59dc30b27b2788d024afd16aa3:

  • A concurrent Jules commit advanced the branch after the prior review note; its final tree was re-fetched and verified without force-push or overwrite.
  • The Devin finding remains resolved: the PR no longer changes the non-canonical .Jules/palette.md; only the two intended report CSS modules differ from origin/main.
  • Exact-head verification: 27 focused tests passed, Ruff passed, interrogate 100% for both changed production modules, and git diff --check passed.

The PR remains on the normal protected auto-merge path.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

Comment on lines +223 to 224
.table-scroll:focus, pre:focus { outline: none; }
.table-scroll:focus-visible, pre:focus-visible { outline: 3px solid Highlight; outline-offset: 3px; }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ“ Info: Focus suppression pattern differs from the main element

The new .table-scroll:focus, pre:focus { outline: none; } paired with the :focus-visible rule below drops the keyboard focus ring on user agents lacking :focus-visible support, since the invalid :focus-visible selector list is discarded. The main element in the same stylesheet deliberately uses main:focus:not(:focus-visible) to keep a fallback (enforced by tests/test_scoring_essay_report_pointer_focus.py:11-12). The container :focus { outline: none; } form is the tested convention elsewhere (tests/test_report_focus_contrast.py:55-56), so this matches existing behavior.

Open in Devin Review

Was this helpful? React with ๐Ÿ‘ or ๐Ÿ‘Ž to provide feedback.

@google-labs-jules

Copy link
Copy Markdown

Current-head reconciliation at exact head baa5c6f675a26f59dc30b27b2788d024afd16aa3:

  • A concurrent Jules commit advanced the branch after the prior review note; its final tree was re-fetched and verified without force-push or overwrite.
  • The Devin finding remains resolved: the PR no longer changes the non-canonical .Jules/palette.md; only the two intended report CSS modules differ from origin/main.
  • Exact-head verification: 27 focused tests passed, Ruff passed, interrogate 100% for both changed production modules, and git diff --check passed.

The PR remains on the normal protected auto-merge path.

Acknowledged. Thanks for the verification.

Copy link
Copy Markdown
Contributor Author

Closing as superseded by the existing report-surface writers after adopting the compatible intent without the blanket-focus selector.

Fresh comparison shows:

  • generic diagnostics python/fast_mlsirm/report.py is already owned by fix(report): replay main focus accessibility on current review workflowย #1002 at 36e0bdd71535e56fe1329f31c2cd74d0749c64d8, where pointer suppression uses :focus:not(:focus-visible) and regressions explicitly reject blanket :focus { outline: none; };
  • essay python/fast_mlsirm/scoring/essay/report_html.py is owned by fix(report): harden essay titles and semantic row headersย #997. I added RED b01ba1ba90408242c365605f7b4b8cc6c61a1037, GREEN 18b213520257a038accf4317a104c3cc0bfe06c5, and changelog 47ec832f95e0ea0a31715212bd965325c28a4542 there so .table-scroll and canonical JSON <pre> suppress pointer-acquired outlines only under :focus:not(:focus-visible), while keyboard focus remains explicit.

#1143's blanket .table-scroll:focus, pre:focus { outline: none; } and summary :focus rules therefore duplicate/conflict with the repository's established modality-safe contract. No #1143 commit will be merged independently.

@seonghobae seonghobae closed this Aug 21, 2026
auto-merge was automatically disabled August 21, 2026 08:06

Pull request was closed

@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by the existing report-surface writers after adopting the compatible intent without the blanket-focus selector.

Fresh comparison shows:

  • generic diagnostics python/fast_mlsirm/report.py is already owned by fix(report): replay main focus accessibility on current review workflowย #1002 at 36e0bdd71535e56fe1329f31c2cd74d0749c64d8, where pointer suppression uses :focus:not(:focus-visible) and regressions explicitly reject blanket :focus { outline: none; };
  • essay python/fast_mlsirm/scoring/essay/report_html.py is owned by fix(report): harden essay titles and semantic row headersย #997. I added RED b01ba1ba90408242c365605f7b4b8cc6c61a1037, GREEN 18b213520257a038accf4317a104c3cc0bfe06c5, and changelog 47ec832f95e0ea0a31715212bd965325c28a4542 there so .table-scroll and canonical JSON <pre> suppress pointer-acquired outlines only under :focus:not(:focus-visible), while keyboard focus remains explicit.

#1143's blanket .table-scroll:focus, pre:focus { outline: none; } and summary :focus rules therefore duplicate/conflict with the repository's established modality-safe contract. No #1143 commit will be merged independently.

Understood. Acknowledging that this work is now obsolete and superseded by the correct modality-safe :focus:not(:focus-visible) implementation in existing PRs. Stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant