Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Seal enterprise observation admission

## Fixed

- Enterprise issue observation admission now rejects caller-defined scoring-request, evidence-reference, and status-string subclasses before reading provenance or performing enum lookup, preventing caller callbacks during semantic validation while preserving exact package records and serialized status strings.
12 changes: 9 additions & 3 deletions python/fast_mlsirm/scoring/enterprise_issue/observation.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,14 @@

def _observation_status(value: ObservationStatus | str) -> ObservationStatus:
"""Return one supported observation status with a stable failure boundary."""
if isinstance(value, ObservationStatus):
if type(value) is ObservationStatus:
return value
if type(value) is not str:
raise assessment_error(
"invalid_observation_status",
"$.status",
"status must be a supported observation status",
)
try:
return ObservationStatus(value)
except Exception:
Expand All @@ -53,7 +59,7 @@ def _enterprise_request_context(
request: ScoringRequest,
) -> tuple[str, str, frozenset[str], bool]:
"""Return verified enterprise provenance carried by one shared request."""
if not isinstance(request, ScoringRequest):
if type(request) is not ScoringRequest:
raise assessment_error(
"invalid_scoring_request",
"$.request",
Expand Down Expand Up @@ -143,7 +149,7 @@ def _observation_evidence(
maximum=MAX_EVIDENCE_REFERENCES,
)
for index, value in enumerate(raw):
if not isinstance(value, EvidenceReference):
if type(value) is not EvidenceReference:
raise assessment_error(
"invalid_evidence_reference",
f"$.evidence_references[{index}]",
Expand Down
79 changes: 79 additions & 0 deletions tests/test_scoring_enterprise_issue_observation_callback_safety.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
"""Regression tests for callback-free enterprise observation admission."""

from __future__ import annotations

from typing import Any

import pytest

from fast_mlsirm.scoring import (
AssessmentSpecError,
EvidenceReference,
ObservationStatus,
ScoringRequest,
)
from fast_mlsirm.scoring.enterprise_issue.observation import (
_enterprise_request_context,
_observation_evidence,
_observation_status,
)


def _hostile_record(record_type: type[Any]) -> tuple[Any, list[str]]:
"""Return an uninitialized subclass that records any instance attribute read."""

callbacks: list[str] = []

class HostileRecord(record_type): # type: ignore[misc, valid-type]
def __getattribute__(self, name: str) -> Any:
if name.startswith("__"):
return object.__getattribute__(self, name)
callbacks.append(name)
raise AssertionError(f"caller callback executed for {name}")

return object.__new__(HostileRecord), callbacks


def test_enterprise_request_context_rejects_subclass_before_metadata_callback() -> None:
"""Request provenance is not read from a caller-defined request subclass."""

request, callbacks = _hostile_record(ScoringRequest)

with pytest.raises(AssessmentSpecError) as caught:
_enterprise_request_context(request)

assert caught.value.code == "invalid_scoring_request"
assert callbacks == []


def test_observation_evidence_rejects_subclass_before_fingerprint_callback() -> None:
"""Evidence provenance is not read from a caller-defined reference subclass."""

reference, callbacks = _hostile_record(EvidenceReference)

with pytest.raises(AssessmentSpecError) as caught:
_observation_evidence((reference,), available_fingerprints=frozenset())

assert caught.value.code == "invalid_evidence_reference"
assert callbacks == []


def test_observation_status_rejects_string_subclass_before_enum_callbacks() -> None:
"""Status parsing rejects caller-defined strings before enum hash/equality lookup."""

callbacks: list[str] = []

class HostileStatus(str):
def __hash__(self) -> int:
callbacks.append("hash")
raise AssertionError("caller hash callback executed")

def __eq__(self, other: object) -> bool:
callbacks.append("eq")
raise AssertionError("caller equality callback executed")

with pytest.raises(AssessmentSpecError) as caught:
_observation_status(HostileStatus(ObservationStatus.SCORED.value))

assert caught.value.code == "invalid_observation_status"
assert callbacks == []
Loading