fix(rotation): replay semantic control hardening on current review workflow - #1013
Conversation
|
Warning Review limit reached
Next review available in: 55 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@opencode-agent @cwl-noema-review Please independently review exact current head |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headdcf2ee03f01de100c3571c48ce9b87e769fb7f9c. -
Head SHA:
dcf2ee03f01de100c3571c48ce9b87e769fb7f9c -
Workflow run: 32213341852
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Docs: 983-rotation-control-boundary.md"]
S1 --> I1["operator or user guidance"]
I1 --> R1["Review risk: Docs: 983-rotation-control-boundary.md"]
R1 --> V1["docs review"]
Evidence --> S2["Changed file (2 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (2 files)"]
R2 --> V2["required checks"]
Evidence --> S3["Test (3 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (3 files)"]
R3 --> V3["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Docs: 983-rotation-control-boundary.md"]
S1 --> I1["operator or user guidance"]
I1 --> R1["Review risk: Docs: 983-rotation-control-boundary.md"]
R1 --> V1["docs review"]
Evidence --> S2["Changed file (2 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (2 files)"]
R2 --> V2["required checks"]
Evidence --> S3["Test (3 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (3 files)"]
R3 --> V3["targeted test run"]
|
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headdcf2ee03f01de100c3571c48ce9b87e769fb7f9c. -
Head SHA:
dcf2ee03f01de100c3571c48ce9b87e769fb7f9c -
Workflow run: 32217717573
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Docs: 983-rotation-control-boundary.md"]
S1 --> I1["operator or user guidance"]
I1 --> R1["Review risk: Docs: 983-rotation-control-boundary.md"]
R1 --> V1["docs review"]
Evidence --> S2["Changed file (2 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (2 files)"]
R2 --> V2["required checks"]
Evidence --> S3["Test (3 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (3 files)"]
R3 --> V3["targeted test run"]
|
@opencode-agent review Fresh re-review request: ContextualWisdomLab/.github#1136 has merged, fixing the central Generated by Claude Code |
|
@opencode-agent review Re-dispatch unchanged exact head |
|
@opencode-agent review Fresh exact-head re-dispatch after central review authority advanced to |
|
@opencode-agent review Please re-review exact current head |
|
@opencode-agent review\n@cwl-noema-review review\n\nPlease review exact current head dcf2ee0. Bind every review and approval decision to this SHA and current main. Existing review state is not sufficient evidence for this head; use current Checks and changed-file evidence only. |
|
Current-head re-review request for |
|
@opencode-agent @cwl-noema-review Re-review the exact current head The prior current-head REQUEST_CHANGES only reported unavailable/failed coverage evidence from an earlier run. Current CI, Security Scan, SAST Semgrep, and CodeQL runs for this exact head are terminal-success. Re-evaluate this head and publish independent approvals only from fresh evidence; do not reuse prior-head reviews. Protected merge policy remains unchanged. |
|
@opencode-agent Please perform a review-only formal review of exact current PR head |
|
Current-head manual review completed for dcf2ee0. Rotation and selector trust boundaries are correctly centralized: exact built-in and concrete NumPy booleans, integers, and finite reals are normalized before native discovery; caller-defined text/scalar subclasses are rejected; target/weight validation and Rust-owned rotation, gradients, multistart, bootstrap, and policy arithmetic remain intact. Focused safety/compatibility validation passed 66 tests; 3 native-execution compatibility tests could not run in this detached checkout because fast_mlsirm._core is not compiled, while hosted CI Rust/CI checks are green. Ruff, interrogate 100 percent, compileall, and diff check are clean. No actionable source defect found; normal merge remains subject to independent formal approval. |
|
Fresh exact-head re-review requested for dcf2ee0. The two existing OpenCode CHANGES_REQUESTED reviews are coverage-evidence failures from 2026-08-19; current-head CI, security, Noema, Strix, and coverage evidence are terminal-success. Re-evaluate this unchanged head under the repaired central coverage contract and publish a fresh formal decision. No bypass or self-approval. |
|
Scheduled review-feedback autofix for this PR head.
|
opencode-agent
Bot
added
area: ci-cd
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Supersedes #984 without changing its corrected product tree.
Exact source head:
dcf2ee03f01de100c3571c48ce9b87e769fb7f9c. Repository CI, Security Scan, CodeQL, and Semgrep are terminal-success on this SHA, with no unresolved review threads. The implementation admits rotation/criterion/policy semantic controls before native discovery without caller-controlled text/numeric callback dispatch, while preserving concrete NumPy scalar compatibility through genuine Rust execution.Rotation objectives, gradients, GPA optimization, multi-start convergence, bootstrap diagnostics, policy scoring, and selection arithmetic remain Rust-owned; Python performs validation/marshalling only.
#984's remaining formal OpenCode
CHANGES_REQUESTEDis solely central coverage-evidence run32124695117, created before the current organization.githubreview/tooling fixes. This successor creates a fresh pull-request event without source churn, force-push, review dismissal, or gate weakening.